From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751197AbaCHIe0 (ORCPT ); Sat, 8 Mar 2014 03:34:26 -0500 Received: from mail-pb0-f42.google.com ([209.85.160.42]:63317 "EHLO mail-pb0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750925AbaCHIeV (ORCPT ); Sat, 8 Mar 2014 03:34:21 -0500 Date: Sat, 08 Mar 2014 17:34:02 +0900 Message-ID: <87bnxhnl6t.wl%satoru.takeuchi@gmail.com> From: Satoru Takeuchi To: Steven Rostedt Cc: Satoru Takeuchi , LKML Subject: Re: [PATCH 1/2] ktest: add 2nd parameter of run_command() to set the redirect target file In-Reply-To: <20140307194328.038b5a12@gandalf.local.home> References: <87vbvwokq8.wl%satoru.takeuchi@gmail.com> <878uslft00.wl%satoru.takeuchi@gmail.com> <20140307194328.038b5a12@gandalf.local.home> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/23.4 Mule/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 7 Mar 2014 19:43:28 -0500, Steven Rostedt wrote: > > On Sat, 08 Mar 2014 09:12:31 +0900 > Satoru Takeuchi wrote: > > > Hi Steven, > > > > At Sun, 02 Mar 2014 21:20:31 +0900, > > Satoru Takeuchi wrote: > > > > > > From: Satoru Takeuchi > > > > > > If we'd like to set the redirect target file of run_command(), > > > we should define $redirect before calling this function and should undef it > > > after calling this function. Since it's user-unfriendly, add 2nd parameter of > > > run_command() for this purpose. > > > > > > Signed-off-by: Satoru Takeuchi > > > Cc: Steven Rostedt > > > > Could you tell whether this patch will be applied? Although you told me that you > > won't apply the following patch, I didn't hear about this patch. > > Ah, I was thinking this one was needed for the next patch, so I didn't > apply it. The two patches don't depend on earch other. > > > > > > [PATCH 2/2] ktest: run make mrproper not only for OUTPUT_DIR but also for BUILD_DIR to avoid build failure > > > > I make this question since I'll send next patch set this weekend and want to > > know whether I can make patch on the top of this patch. > > You can add this one again. I haven't really reviewed it, but if other > patches depend on it, include it as well. Include it anyway if you want > me to review it. OK, I'll resend patch 1/2 at the next post of my patchset. Thanks, Satoru > > Thanks, > > -- Steve > >