mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Dave Jones <davej@redhat.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Cc: mst@redhat.com
Subject: Re: Add missing module license tag to vring helpers.
Date: Mon, 06 May 2013 17:06:23 +0930	[thread overview]
Message-ID: <87bo8opnk8.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20130503204009.GA29376@redhat.com>

Dave Jones <davej@redhat.com> writes:
> [  624.286653] vringh: module license 'unspecified' taints kernel.
>
> Signed-off-by: Dave Jones <davej@redhat.com>

Thanks!  This is exactly right.

But note that the default license tag for otherwise-unlabelled modules
would be "GPLv2".  "GPL" means v2 or later (which is what I want, but
it's not the kernel default).

Applied,
Rusty.

> diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c
> index bff0775..5174eba 100644
> --- a/drivers/vhost/vringh.c
> +++ b/drivers/vhost/vringh.c
> @@ -3,6 +3,7 @@
>   *
>   * Since these may be in userspace, we use (inline) accessors.
>   */
> +#include <linux/module.h>
>  #include <linux/vringh.h>
>  #include <linux/virtio_ring.h>
>  #include <linux/kernel.h>
> @@ -1005,3 +1006,5 @@ int vringh_need_notify_kern(struct vringh *vrh)
>  	return __vringh_need_notify(vrh, getu16_kern);
>  }
>  EXPORT_SYMBOL(vringh_need_notify_kern);
> +
> +MODULE_LICENSE("GPL");

  reply	other threads:[~2013-05-06  7:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-03 20:40 Dave Jones
2013-05-06  7:36 ` Rusty Russell [this message]
2013-05-06 13:41   ` Dave Jones
2013-05-07 11:59     ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bo8opnk8.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®