mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Namjae Jeon <namjae.jeon@samsung.com>,
	Ravishankar N <ravi.n1@samsung.com>
Subject: Re: [PATCH v2] fat: eliminate iterations in fat_search_long and __fat_readdir in case of EOD
Date: Thu, 07 Feb 2013 20:45:14 +0900	[thread overview]
Message-ID: <87bobw4ab9.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <1359989028-7457-1-git-send-email-linkinjeon@gmail.com> (Namjae Jeon's message of "Mon, 4 Feb 2013 23:43:47 +0900")

Namjae Jeon <linkinjeon@gmail.com> writes:

> From: Namjae Jeon <namjae.jeon@samsung.com>
>
> When doing lookups via fat_search_long(), we can stop checking for
> further entries if we detect End of Directory, i.e. if (de->name[0] ==
> 0x00).The current code traverses the cluster chain of a directory until a hit
> is found or till the last cluster for that directory, ignoring the EOD
> mark. Fix this.
>
> Likewise,when readdir(3) is called, we can stop checking for further
> entries in __fat_readdir() when we hit EOD.

Don't we need to change fat_get_short_entry()? And did this work
correctly about f_pos for readdir?

I'm not thinking about f_pos deeply though, it may have something
wrong. Because it stops at middle of cluster.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

  reply	other threads:[~2013-02-07 11:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-04 14:43 Namjae Jeon
2013-02-07 11:45 ` OGAWA Hirofumi [this message]
2013-02-08  6:34   ` Namjae Jeon
2013-02-08  7:14     ` OGAWA Hirofumi
2013-02-09  2:15       ` Namjae Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bobw4ab9.fsf@devron.myhome.or.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=akpm@linux-foundation.org \
    --cc=linkinjeon@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namjae.jeon@samsung.com \
    --cc=ravi.n1@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome