From: Namhyung Kim <namhyung@kernel.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Alessio Igor Bogani <abogani@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Chris Metcalf <cmetcalf@tilera.com>,
Christoph Lameter <cl@linux.com>,
Geoff Levand <geoff@infradead.org>,
Gilad Ben Yossef <gilad@benyossef.com>,
Hakan Akkan <hakanakkan@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 21/27] nohz: Only stop the tick on RCU nocb CPUs
Date: Wed, 02 Jan 2013 17:47:33 +0900 [thread overview]
Message-ID: <87bod8rmxm.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <1356799386-4212-22-git-send-email-fweisbec@gmail.com> (Frederic Weisbecker's message of "Sat, 29 Dec 2012 17:43:00 +0100")
Hi Frederic,
On Sat, 29 Dec 2012 17:43:00 +0100, Frederic Weisbecker wrote:
> On a full dynticks CPU, we want the RCU callbacks to be
> offlined to another CPU, otherwise we need to keep
> the tick to wait for the grace period completion.
>
> Ensure the full dynticks CPU is also an rcu_nocb one.
[snip]
> -static bool is_nocb_cpu(int cpu)
> -{
> - return false;
> -}
> -
You may want to add the following also to shut up the gcc:
CC kernel/rcutree.o
In file included from /home/namhyung/project/linux/kernel/rcutree.c:58:0:
/home/namhyung/project/linux/kernel/rcutree.h:539:13: warning: ‘is_nocb_cpu’ declared ‘static’ but never defined [-Wunused-function]
Thanks,
Namhyung
diff --git a/kernel/rcutree.h b/kernel/rcutree.h
index 4b69291b093d..fbbad931c36a 100644
--- a/kernel/rcutree.h
+++ b/kernel/rcutree.h
@@ -536,7 +536,6 @@ static void print_cpu_stall_info(struct rcu_state *rsp, int cpu);
static void print_cpu_stall_info_end(void);
static void zero_cpu_stall_ticks(struct rcu_data *rdp);
static void increment_cpu_stall_ticks(void);
-static bool is_nocb_cpu(int cpu);
static bool __call_rcu_nocb(struct rcu_data *rdp, struct rcu_head *rhp,
bool lazy);
static bool rcu_nocb_adopt_orphan_cbs(struct rcu_state *rsp,
next prev parent reply other threads:[~2013-01-02 8:47 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-29 16:42 [ANNOUNCE] 3.8-rc1-nohz1 Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 01/27] context_tracking: Add comments on interface and internals Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 02/27] cputime: Generic on-demand virtual cputime accounting Frederic Weisbecker
2013-01-04 20:19 ` Paul Gortmaker
2013-01-08 23:54 ` Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 03/27] cputime: Allow dynamic switch between tick/virtual based " Frederic Weisbecker
2013-01-04 22:16 ` Paul Gortmaker
2013-01-07 15:47 ` Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 04/27] cputime: Use accessors to read task cputime stats Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 05/27] cputime: Safely read cputime of full dynticks CPUs Frederic Weisbecker
2012-12-31 5:54 ` Li Zhong
2013-01-04 13:42 ` Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 06/27] nohz: Basic full dynticks interface Frederic Weisbecker
2012-12-31 7:18 ` Li Zhong
2013-01-04 13:24 ` Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 07/27] nohz: Assign timekeeping duty to a non-full-nohz CPU Frederic Weisbecker
2013-01-02 15:30 ` Christoph Lameter
2013-01-04 12:51 ` Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 08/27] nohz: Trace timekeeping update Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 09/27] nohz: Wake up full dynticks CPUs when a timer gets enqueued Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 10/27] rcu: Restart the tick on non-responding full dynticks CPUs Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 11/27] sched: Comment on rq->clock correctness in ttwu_do_wakeup() in nohz Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 12/27] sched: Update rq clock on nohz CPU before migrating tasks Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 13/27] sched: Update rq clock on nohz CPU before setting fair group shares Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 14/27] sched: Update rq clock on tickless CPUs before calling check_preempt_curr() Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 15/27] sched: Update rq clock earlier in unthrottle_cfs_rq Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 16/27] sched: Update clock of nohz busiest rq before balancing Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 17/27] sched: Update rq clock before idle balancing Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 18/27] sched: Update nohz rq clock before searching busiest group on load balancing Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 19/27] nohz: Move nohz load balancer selection into idle logic Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 20/27] nohz: Full dynticks mode Frederic Weisbecker
2012-12-29 16:43 ` [PATCH 21/27] nohz: Only stop the tick on RCU nocb CPUs Frederic Weisbecker
2013-01-02 8:47 ` Namhyung Kim [this message]
2013-01-04 12:53 ` Frederic Weisbecker
2012-12-29 16:43 ` [PATCH 22/27] nohz: Don't turn off the tick if rcu needs it Frederic Weisbecker
2012-12-29 16:43 ` [PATCH 23/27] nohz: Don't stop the tick if posix cpu timers are running Frederic Weisbecker
2012-12-29 16:43 ` [PATCH 24/27] nohz: Add some tracing Frederic Weisbecker
2012-12-29 16:43 ` [PATCH 25/27] rcu: Don't keep the tick for RCU while in userspace Frederic Weisbecker
2012-12-29 16:43 ` [PATCH 26/27] profiling: Remove unused timer hook Frederic Weisbecker
2012-12-29 16:43 ` [PATCH 27/27] timer: Don't run non-pinned timer to full dynticks CPUs Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bod8rmxm.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=abogani@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=cmetcalf@tilera.com \
--cc=fweisbec@gmail.com \
--cc=geoff@infradead.org \
--cc=gilad@benyossef.com \
--cc=hakanakkan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome