From: ebiederm@xmission.com (Eric W. Biederman)
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Ian Kent <raven@themaw.net>,
autofs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, sukadev@linux.vnet.ibm.com,
serge.hallyn@canonical.com, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 1/2] autofs4: allow autofs to work outside the initial PID namespace
Date: Mon, 26 Nov 2012 08:38:58 -0600 [thread overview]
Message-ID: <87boekzawt.fsf@xmission.com> (raw)
In-Reply-To: <CAJfpegsqwd57NdHVhwfdNjauj8HKJb=x+2GAZtJQ8vLdt+A=sw@mail.gmail.com> (Miklos Szeredi's message of "Mon, 26 Nov 2012 09:05:46 +0100")
Miklos Szeredi <miklos@szeredi.hu> writes:
> On Mon, Nov 26, 2012 at 3:29 AM, Ian Kent <raven@themaw.net> wrote:
>>> > > MS_UNBINDABLE says: skip this mount when copying a mount tree, such
>>> > > as when the mount namespace is cloned.
>>> > >
>>> > > If you set MS_UNBINDABLE on autofs mounts then they will simply not
>>> > > appear in a cloned namespace. Which sounds like a good idea, no?
>>> >
>>> > Good point. If the desire is for a mount to be managed by autofs
>>> > setting MS_UNBINDABLE seems required.
>>>
>>> Arrgh, I know that's something I should have looked into long ago.
>>> The fact is that autofs mounts are directly related to a specific path
>>> defined by automount maps that are associated with the daemon so bind
>>> mounting them elsewhere makes no sense.
>>
>> Except, AFAICS, they do appear in the clone.
>
> Hmm, yes, apparently the semantics of MS_UNBINDABLE only apply to
> actual bind mounts not to namespace cloning. Even though the two
> operations are closely related. Not sure why this is so, but it is
> probably not a good idea to change the semantics at this point.
And for whatever reason this appears deliberate.
CL_COPY_ALL in copy_tree allows the copy.
The selected semantics of namespace sharing tend to mystify me.
So I don't know how much MS_UNBINDABLE helps over MS_PRIVATE. Both
prevent propogation of changes to other namespaces. I don't know how
much using MS_UNBINDABLE to also prevent bind mounts helps.
Eric
next prev parent reply other threads:[~2012-11-26 14:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 16:24 Miklos Szeredi
2012-11-22 16:26 ` [PATCH 2/2] autofs4: translate pids to the right namespace for the daemon Miklos Szeredi
2012-11-23 3:45 ` [PATCH 1/2] autofs4: allow autofs to work outside the initial PID namespace Ian Kent
2012-11-23 12:09 ` Ian Kent
2012-11-23 14:30 ` Miklos Szeredi
2012-11-24 2:23 ` Ian Kent
2012-11-24 2:37 ` Ian Kent
2012-11-24 12:07 ` Eric W. Biederman
2012-11-24 21:12 ` Miklos Szeredi
2012-11-24 22:35 ` Eric W. Biederman
2012-11-25 23:25 ` Ian Kent
2012-11-26 2:29 ` Ian Kent
2012-11-26 8:05 ` Miklos Szeredi
2012-11-26 14:38 ` Eric W. Biederman [this message]
2012-11-26 16:11 ` Miklos Szeredi
[not found] <20131115222222.6F70A1CA1A1@corp2gmr1-1.eem.corp.google.com>
2013-11-16 16:03 ` [patch " Oleg Nesterov
2013-11-18 3:04 ` Ian Kent
2013-11-18 18:22 ` Oleg Nesterov
-- strict thread matches above, loose matches on Subject: below --
2013-05-07 13:54 [PATCH " Miklos Szeredi
2013-05-07 18:14 ` Serge E. Hallyn
2012-11-13 11:48 Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87boekzawt.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=autofs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=raven@themaw.net \
--cc=serge.hallyn@canonical.com \
--cc=sukadev@linux.vnet.ibm.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome