From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Cruz Julian Bishop <cruzjbishop@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] fs/fat: Fix all other checkpatch issues in dir.c
Date: Sun, 12 Aug 2012 19:14:08 +0900 [thread overview]
Message-ID: <87boigbeof.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <1344764687-4155-7-git-send-email-cruzjbishop@gmail.com> (Cruz Julian Bishop's message of "Sun, 12 Aug 2012 19:44:46 +1000")
Cruz Julian Bishop <cruzjbishop@gmail.com> writes:
> + charlen = t->char2uni(&nc, 1, uni);
> +
Here is strange new line.
> + if (charlen < 0) {
> *uni = 0x003f; /* a question mark */
> charlen = 1;
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2012-08-12 10:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-12 9:44 [PATCH 0/7] Fat checkstyle patch set (1) Cruz Julian Bishop
2012-08-12 9:44 ` [PATCH 1/7] fs/fat: Fix a checkpatch issue in namei_msdos.c Cruz Julian Bishop
2012-08-12 9:44 ` [PATCH 2/7] fs/fat: Fix some checkpatch issues in fat.h Cruz Julian Bishop
2012-08-12 9:44 ` [PATCH 3/7] fs/fat: Changed indentation of some comments " Cruz Julian Bishop
2012-08-12 9:44 ` [PATCH 4/7] fs/fat: Fix two checkpatch issues in cache.c Cruz Julian Bishop
2012-08-12 9:44 ` [PATCH 5/7] fs/fat: Fixes some small checkpatch issues in dir.c Cruz Julian Bishop
2012-08-12 9:44 ` [PATCH 6/7] fs/fat: Fix all other " Cruz Julian Bishop
2012-08-12 10:14 ` OGAWA Hirofumi [this message]
2012-08-12 9:44 ` [PATCH 7/7] fs/fat: Fix checkpatch issues in fatent.c Cruz Julian Bishop
2012-08-12 10:18 ` [PATCH 0/7] Fat checkstyle patch set (1) OGAWA Hirofumi
2012-08-12 11:01 ` Cruz Julian Bishop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87boigbeof.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=cruzjbishop@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome