From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Nikolaus Schulz <microschulz@web.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Marton Balint <cus@fazekas.hu>,
Alexey Dobriyan <adobriyan@gmail.com>,
Kevin Dankwardt <k@kcomputing.com>,
Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH] fat: fix buffer overflow in vfat_create_shortname()
Date: Thu, 25 Mar 2010 21:52:12 +0900 [thread overview]
Message-ID: <87bpec4l8j.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <87y6hg60nw.fsf@devron.myhome.or.jp> (OGAWA Hirofumi's message of "Thu, 25 Mar 2010 21:33:39 +0900")
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:
> Nikolaus Schulz <microschulz@web.de> writes:
>
>>> However, anyway, your patch is much better off than current one. So,
>>> I'll apply this in the next merge window.
>>>
>>> Or should we apply this immediately?
>>>
>>> Thanks.
>>
>> Given that this fixes a stack corruption which triggers the gcc stack
>> smashing protection and thus basically a crash, I vote for not
>> postponing it, but applying it immediately.
>
> Um..., where is a stack corruption? sprintf() overflow? But, it's
> actually snprintf(), not sprintf()...
Whoops, it was really sprintf().
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2010-03-25 12:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 3:50 Nikolaus Schulz
2010-03-25 5:30 ` OGAWA Hirofumi
2010-03-25 12:24 ` Nikolaus Schulz
2010-03-25 12:33 ` OGAWA Hirofumi
2010-03-25 12:52 ` OGAWA Hirofumi [this message]
2010-03-31 12:08 ` Nikolaus Schulz
2010-03-31 17:21 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bpec4l8j.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=adobriyan@gmail.com \
--cc=cus@fazekas.hu \
--cc=hch@lst.de \
--cc=k@kcomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=microschulz@web.de \
--cc=stable@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome