mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Ogness <john.ogness@linutronix.de>
To: Tzung-Bi Shih <tzungbi@kernel.org>, Petr Mladek <pmladek@suse.com>
Cc: Kees Cook <kees@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Tony Luck <tony.luck@intel.com>,
	"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	tfiga@chromium.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] printk: Introduce loglevel bypass for pstore console
Date: Thu, 24 Sep 2026 17:28:21 +0206	[thread overview]
Message-ID: <87cxu2u11u.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <aqj426Zjg8pw1I97@google.com>

On 2026-09-15, Tzung-Bi Shih <tzungbi@kernel.org> wrote:
>>> Currently, offline consoles (e.g., pstore_console backed by ramoops)
>>> inherit the system's global console_loglevel.
>>> 
>>> In production environments, physical serial consoles (UARTs) are often
>>> heavily rate-limited to prevent verbose messages from causing severe
>>> execution bottlenecks.  Unfortunately, this identically silences the
>>> pstore console.  When a kernel panic or lockup occurs, engineers are
>>> left inspecting a crash dump that has been stripped of the verbose logs
>>> that could have identified the root cause.
>>> 
>>> This series introduces CON_BYPASS_LOGLEVEL, a simple flag that allows
>>> specialized offline consoles to request unsuppressed logs directly.
>>> 
>>> Patch 1 introduces the CON_BYPASS_LOGLEVEL flag.
>>> Patch 2 adopts the flag in pstore_console.
>> 
>> I believe that a better solution for this problem would be adding
>> the per-console loglevel feature, see
>> https://lore.kernel.org/all/cover.1764272407.git.chris@chrisdown.name/
>> 
>> It is currently blocked by a cleanup of the console registration code,
>> see https://lore.kernel.org/all/20260604101459.393162-1-pmladek@suse.com/
>> 
>> I am going to send v5 of the console registration code cleanup soon,
>> hopefully later this week or the following week. It would be nice
>> when it gets some more review.
>
> Thanks for the context.  I completely agree that the per-console
> loglevel is the proper long-term solution, and I understand that console
> registration cleanup and the larger printk reworks are massive and
> complex efforts.
>
> Because those foundational changes naturally take time, I was wondering
> if we could consider my approach as a narrow and localized exception
> just for offline consoles like pstore.
>
> Given that we already use LOG_FORCE_CON to bypass loglevels on a
> per-message basis, introducing a symmetric per-console flag like
> CON_BYPASS_LOGLEVEL might be an acceptable short-term solution.
>
> Would you be open to a localized flag like this in the interim, or do
> you strongly prefer to hold off until the full per-console loglevel
> architecture lands?

I agree with Petr that we need to go with per-console loglevels here.
However, we really need to prioritize our efforts to get that
per-console loglevel series mainline (which means getting the cleanup
series mainline first).

@Petr: Maybe we can find some time in Prag to sit down together and go
through the rather large queue of various printk series that are waiting
to be reviewed.

John

      reply	other threads:[~2026-09-24 15:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31  7:03 Tzung-Bi Shih
2026-08-31  7:03 ` [PATCH 1/2] printk: Introduce CON_BYPASS_LOGLEVEL flag Tzung-Bi Shih
2026-08-31  7:03 ` [PATCH 2/2] pstore: Bypass loglevel suppression for pstore console Tzung-Bi Shih
2026-09-09  7:44 ` [PATCH 0/2] printk: Introduce loglevel bypass " Tzung-Bi Shih
2026-09-09  9:28 ` Petr Mladek
2026-09-15  7:50   ` Tzung-Bi Shih
2026-09-24 15:22     ` John Ogness [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cxu2u11u.fsf@jogness.linutronix.de \
    --to=john.ogness@linutronix.de \
    --cc=gpiccoli@igalia.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --cc=tfiga@chromium.org \
    --cc=tony.luck@intel.com \
    --cc=tzungbi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®