mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: songxiebing <songxiebing@kylinos.cn>
Cc: tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/conexant: Set mic pin VREF to 0x24 on headset mic plug
Date: Tue, 25 Aug 2026 10:22:56 +0200	[thread overview]
Message-ID: <87cxv6txr3.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260825023855.394959-1-songxiebing@kylinos.cn>

On Tue, 25 Aug 2026 04:38:55 +0200,
songxiebing wrote:
> 
> From: Bob Song <songxiebing@kylinos.cn>
> 
> For 3-pole headset microphones, the mic pin VREF must always be
> configured to 0x24 regardless of the headset type, otherwise the
> mic will not be able to record audio. Move the setting of the mic
> pin widget control to a common path.
> 
> Signed-off-by: Bob Song <songxiebing@kylinos.cn>
> ---
>  sound/hda/codecs/conexant.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/hda/codecs/conexant.c b/sound/hda/codecs/conexant.c
> index 40da2832ba66..a18091a2866f 100644
> --- a/sound/hda/codecs/conexant.c
> +++ b/sound/hda/codecs/conexant.c
> @@ -225,13 +225,12 @@ static void cx_process_headset_plugin(struct hda_codec *codec)
>  	val = snd_hda_codec_read(codec, 0x1c, 0, 0xcb0, 0x0);
>  	if (val & 0x800) {
>  		codec_dbg(codec, "headset plugin, type is CTIA\n");
> -		snd_hda_codec_write(codec, 0x19, 0, AC_VERB_SET_PIN_WIDGET_CONTROL, 0x24);
>  	} else if (val & 0x400) {
>  		codec_dbg(codec, "headset plugin, type is OMTP\n");
> -		snd_hda_codec_write(codec, 0x19, 0, AC_VERB_SET_PIN_WIDGET_CONTROL, 0x24);
>  	} else {
> -		codec_dbg(codec, "headphone plugin\n");
> +		codec_dbg(codec, "mic plugin\n");
>  	}
> +	snd_hda_codec_write(codec, 0x19, 0, AC_VERB_SET_PIN_WIDGET_CONTROL, 0x24);
>  }


Hmm, it's a headset plug check code, and the fallback case you
modified was supposed to be a headphone jack, no microphone.  That is,
the state where a headphone is plugged without microphone into the
headset jack, and in this case, it's wrong to enable the mic pin --
you shouldn't be able to record from the mic at all in this particular
case.

So, there must be other case -- mic-only plug -- and that is where the
mic pin is set up, too.


Takashi

  reply	other threads:[~2026-08-25  8:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25  2:38 songxiebing
2026-08-25  8:22 ` Takashi Iwai [this message]
2026-08-25  9:13 ` songxiebing
2026-08-25  9:28   ` Takashi Iwai
2026-08-25  9:45 ` songxiebing
2026-08-25  9:55   ` Takashi Iwai
2026-08-26  1:12 ` songxiebing
2026-08-26  1:45 ` [PATCH v2] ALSA: hda/conexant: Refactor headset plug detection songxiebing
2026-08-26  8:48   ` Takashi Iwai
2026-08-26 11:53 ` [PATCH v3] ALSA: hda/conexant: Always enable the headset-mic pin on plugin songxiebing
2026-08-26 15:27   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cxv6txr3.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=songxiebing@kylinos.cn \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®