From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6279439332; Mon, 24 Aug 2026 16:05:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787587506; cv=none; b=bNnYSeeUj1eVFTbHYhS2wvqdiewx0jZ29poB0hTzJYuLYb54GZWHuRH8hqtCoWvFPVVHz+R/BLQze3yQ8h20ckxjirv58AfkpGOlhegS4oZ7pUTc8/ASPuPKe8T9PC7gTuzgphI3rByTEr71c2KWYeTTMYo9zwgOpE3Xlzj/2Uo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787587506; c=relaxed/simple; bh=2weL79KO9JXb/r3DhTTH8hvHiBzrxYsznj80Z/lj6fg=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=GEEtwtR2JJm5wsDPZ6nhAW68bWtz3sZXQgKvg9G892+8Zo0Epcu2BuRVZ4RM9J+iT3uc/9OT11p3XDIZGrScGXVLHyYquUw5zc9TdsYxqqYDdP7r0NtjOadU1kj0zwIUpwGEWRNyoKNd4M4DMcoDPbtrkwOTiuhKFJsIgEldJUQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oGuiO1LZ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oGuiO1LZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64AF21F000E9; Mon, 24 Aug 2026 16:05:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787587504; bh=xsGnbQA8QAYssJEiwKJBqXhMXzwX6AojwnfU11zwctw=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=oGuiO1LZ3ig7k40y934Bkb26zxOl+gCmvsoyCPCt41DopBZ07UOx08JFnXCpTAYI6 ljHXRpzeaO7zaI/9raud+2BZ4lYtYscpwPXWe0buj/ypgPejhjTJVFqLG6wBue80NB 2ATPRsC+u5a7/3D/j2efO39bhQyuvjp+X4pxYjN/1n5jS/7ayT9dHjtkEJ2SrBILfS 3Soiu2RKGKoZpxsg2TWYUyKsMraBnYLRm0L2X2h/OJe79ygzHpxrY1bOd50i2TvfnC 9bPCD1Bs4ee++RSM4InUzipMv3/tixwfihPceRiazpRM2NOArkQsxxy/kWn/cJ3TcL ZrxRWzfqMk8rg== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wyXAT-00000000lIs-3GSr; Mon, 24 Aug 2026 16:05:01 +0000 Date: Mon, 24 Aug 2026 17:07:33 +0100 Message-ID: <87cxv7o62i.wl-maz@kernel.org> From: Marc Zyngier To: Julian Braha Cc: florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, linux@armlinux.org.uk, tglx@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de, bcm-kernel-feedback-list@broadcom.com, radu@rendec.net, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, arnd@arndb.de, sudeep.holla@kernel.org, mark.rutland@arm.com, lpieralisi@kernel.org Subject: Re: [PATCH v2] irqchip: gic-v3: fix unmet dependency on ARM_PSCI_FW In-Reply-To: <20260823180832.1246363-1-julianbraha@gmail.com> References: <20260823180832.1246363-1-julianbraha@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: julianbraha@gmail.com, florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, linux@armlinux.org.uk, tglx@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de, bcm-kernel-feedback-list@broadcom.com, radu@rendec.net, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, arnd@arndb.de, sudeep.holla@kernel.org, mark.rutland@arm.com, lpieralisi@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Sun, 23 Aug 2026 19:08:32 +0100, Julian Braha wrote: > > ARM_GIC_V3 currently selects HAVE_ARM_SMCCC_DISCOVERY without ensuring its > dependency, ARM_PSCI_FW, is met. However, ARM_PSCI_FW is always enabled on > for arm64, and the GICv3 driver only uses HAVE_ARM_SMCCC_DISCOVERY to > identify the NVIDIA T241, which is arm64 anyway. > > Also adds fallbacks for callers to avoid needing #ifdef guards when > HAVE_ARM_SMCCC_DISCOVERY is disabled (32bit arm). What does this 'Also' tell you? That this part is in the wrong patch. This should be split in two different patches, fixing different problems. One to allow graceful fallback of the SMCCC_DISCOVERY stuff when it isn't selected, and another to only force the selection of that option on arm64 when GICv3 is selected. > > This unmet dependency was found by kconfirm, a static analysis tool for > Kconfig. I'm not sure this is massively relevant here, but since the trend is to turn commit messages into advertising billboards... M. -- Jazz isn't dead. It just smells funny.