From: Jonathan Corbet <corbet@lwn.net>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH] docs: conf.py: fix the 'utf-8' typo
Date: Tue, 11 Aug 2026 10:46:06 -0600 [thread overview]
Message-ID: <87cxvoli5t.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20260806051115.1235789-1-rdunlap@infradead.org>
Randy Dunlap <rdunlap@infradead.org> writes:
> "encoding" should be 'utf-8'. Fix the typo.
>
> Fixes: 7ea9a550f710 ("docs: conf.py: several coding style fixes")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: Shuah Khan <skhan@linuxfoundation.org>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
>
> Documentation/conf.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20260805.orig/Documentation/conf.py
> +++ linux-next-20260805/Documentation/conf.py
> @@ -287,7 +287,7 @@ author = "The kernel development communi
> try:
> makefile_version = None
> makefile_patchlevel = None
> - with open("../Makefile", encoding="utf=8") as fp:
> + with open("../Makefile", encoding="utf-8") as fp:
> for line in fp:
So this is somewhat weird... open() will throw an exception with an
unknown encoding, but takes "utf=8" without complaint. Somehow they are
explicitly handling that case. So the code is arguably correct :)
That said, I've applied the patch, thanks.
jon
next prev parent reply other threads:[~2026-08-11 16:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 5:11 Randy Dunlap
2026-08-11 16:46 ` Jonathan Corbet [this message]
2026-08-14 22:54 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cxvoli5t.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®