From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out01.mta.xmission.com (out01.mta.xmission.com [166.70.13.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C9D018B0F for ; Fri, 26 Jun 2026 17:12:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=166.70.13.231 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782493933; cv=none; b=dkK7Kp/vje+tKv7tubdvbgNcK21zc2dQSeO3exm96psWbClOXJVFKGzrYmg8r3S8B/a9tIp25PCWoP2e4ywDhQnWpnGDpXu2JBiYZiT4YfGILzKCwk/qRhFkC7h5XArCMORubqXs48m1J8qwGGAJywVJydr+MSpaMd5VKRifpF8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782493933; c=relaxed/simple; bh=ixlMocYjDCxRT1zwwBh9UamstbMucj9ezd5YACwiDs8=; h=From:To:Cc:In-Reply-To:References:Date:Message-ID:MIME-Version: Content-Type:Subject; b=ty4bKJ0T+zbRxCmffSm5nV5/7eh0g3amsbyxCmgGSqGtvXHYw4K2vD2v4kwDJv6GlSiLeF9BZZ4vk3k5Q370eQ6rwLbauPa6rWvimclY0zgPLlODETJ8k340Ur2XiPTqv55/l+HIiwji0xfo0a6kMQo+lIGaC1pJFjSbU9VqXyk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xmission.com; spf=pass smtp.mailfrom=xmission.com; dkim=pass (1024-bit key) header.d=xmission.com header.i=@xmission.com header.b=ILZLPOWm; arc=none smtp.client-ip=166.70.13.231 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xmission.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xmission.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=xmission.com header.i=@xmission.com header.b="ILZLPOWm" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=xmission.com; s=xmission; h=Subject:Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ixlMocYjDCxRT1zwwBh9UamstbMucj9ezd5YACwiDs8=; b=ILZLPOWm+zd6z6/GCs80h3F3PE WUXQ5N7YzR/mL69syY4bDscMOqhVHcXPJpSEk3BlOiFCt8QF4LFUOOKAEhDHEnohoeAVsjWLRvAgx Afl9RHzS0FDzHKZjZKUXEdmrKaSmE7x0A32Uh0c/d/S3uwUa03nxYAKkkh3sszdTnhsU=; Received: from in01.mta.xmission.com ([166.70.13.51]:47542) by out01.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1wd9pJ-004sPD-LV; Fri, 26 Jun 2026 10:54:49 -0600 Received: from ip72-198-198-28.om.om.cox.net ([72.198.198.28]:47524 helo=email.froward.int.ebiederm.org.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1wd9pI-00GjsH-Qm; Fri, 26 Jun 2026 10:54:49 -0600 From: "Eric W. Biederman" To: Andrew Morton Cc: Andy Lutomirski , Kees Cook , Kusaram Devineni , Peter Zijlstra , Thomas Gleixner , Will Drewry , linux-kernel@vger.kernel.org, Oleg Nesterov In-Reply-To: <87o6gx9rc4.fsf@email.froward.int.ebiederm.org> (Eric W. Biederman's message of "Fri, 26 Jun 2026 11:52:43 -0500") References: <87o6gx9rc4.fsf@email.froward.int.ebiederm.org> Date: Fri, 26 Jun 2026 11:54:43 -0500 Message-ID: <87cxxd9r8s.fsf_-_@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1wd9pI-00GjsH-Qm;;;mid=<87cxxd9r8s.fsf_-_@email.froward.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=72.198.198.28;;;frm=ebiederm@xmission.com;;;sPfnum=0;;;sPf=pass X-XM-AID: U2FsdGVkX1/4izO4/2t7pU0+Bdvqc8O35/ayT/J47js= X-Spam-Level: * X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.1 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.7 XMSubLong Long Subject * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa05 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa05 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *;Andrew Morton X-Spam-Relay-Country: X-Spam-Timing: total 372 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 10 (2.7%), b_tie_ro: 9 (2.4%), parse: 0.90 (0.2%), extract_message_metadata: 11 (2.9%), get_uri_detail_list: 1.38 (0.4%), tests_pri_-2000: 13 (3.5%), tests_pri_-1000: 2.6 (0.7%), tests_pri_-950: 1.22 (0.3%), tests_pri_-900: 0.96 (0.3%), tests_pri_-90: 55 (14.7%), check_bayes: 53 (14.3%), b_tokenize: 7 (1.9%), b_tok_get_all: 6 (1.6%), b_comp_prob: 1.92 (0.5%), b_tok_touch_all: 35 (9.4%), b_finish: 0.87 (0.2%), tests_pri_0: 266 (71.4%), check_dkim_signature: 0.55 (0.1%), check_dkim_adsp: 2.9 (0.8%), poll_dns_idle: 0.96 (0.3%), tests_pri_10: 1.90 (0.5%), tests_pri_500: 8 (2.1%), rewrite_mail: 0.00 (0.0%) Subject: [PATCH 02/11] signal: In get_signal call do_exit when it is unnecessary to shoot down threads X-SA-Exim-Connect-IP: 166.70.13.51 X-SA-Exim-Rcpt-To: oleg@redhat.com, linux-kernel@vger.kernel.org, wad@chromium.org, tglx@kernel.org, peterz@infradead.org, kusaram@devineni.in, kees@kernel.org, luto@kernel.org, akpm@linux-foundation.org X-SA-Exim-Mail-From: ebiederm@xmission.com X-SA-Exim-Scanned: No (on out01.mta.xmission.com); SAEximRunCond expanded to false In get_signal if other threads of the current process do not need to be shot down calling do_group_exit is equivalent to calling do_exit. The code in get_signal is only responsible for shooting down threads when it dequeues a signal and decides the signal is fatal. To remove special cases and make the code easier to read, call do_exit instead of do_group_exit when no other threads need to be shot down. With do_group_exit no longer being called when exec is terminating threads in de_thread remove the special case in do_group_exit for handling exec. Signed-off-by: "Eric W. Biederman" --- kernel/exit.c | 4 ---- kernel/signal.c | 7 ++++++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/kernel/exit.c b/kernel/exit.c index ae143be7c831..4bfecf2a510d 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -1097,8 +1097,6 @@ do_group_exit(int exit_code) if (sig->flags & SIGNAL_GROUP_EXIT) exit_code = sig->group_exit_code; - else if (sig->group_exec_task) - ; else { struct sighand_struct *const sighand = current->sighand; @@ -1106,8 +1104,6 @@ do_group_exit(int exit_code) if (sig->flags & SIGNAL_GROUP_EXIT) /* Another thread got here before we took the lock. */ exit_code = sig->group_exit_code; - else if (sig->group_exec_task) - ; else { sig->group_exit_code = exit_code; sig->flags = SIGNAL_GROUP_EXIT; diff --git a/kernel/signal.c b/kernel/signal.c index 39fbf9c9474a..d98307964ee5 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -2863,6 +2863,7 @@ bool get_signal(struct ksignal *ksig) } for (;;) { + bool group_exit_needed = false; struct k_sigaction *ka; enum pid_type type; int exit_code = 0; @@ -3005,6 +3006,7 @@ bool get_signal(struct ksignal *ksig) * Anything else is fatal, maybe with a core dump. */ exit_code = signr; + group_exit_needed = true; fatal: spin_unlock_irq(&sighand->siglock); if (unlikely(cgroup_task_frozen(current))) @@ -3039,7 +3041,10 @@ bool get_signal(struct ksignal *ksig) /* * Death signals, no core dump. */ - do_group_exit(exit_code); + if (group_exit_needed) + do_group_exit(exit_code); + else + do_exit(exit_code); /* NOTREACHED */ } spin_unlock_irq(&sighand->siglock); -- 2.41.0