From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34958223DD6 for ; Thu, 5 Mar 2026 10:36:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772707007; cv=none; b=Y4yYCvBSAxwMUP2mIIPjnO26tHR82vXsyJy8+S+UWasa846+aD/sNx5uKqC2A6j+VdZnJOH0zaK2tbCogbLZ9/UjqvVdsQzlvKU14RF0db9t7auJ9LIY32qWFn9aio/SnALdmPFekX+zS3D95te5QdCZJlEqNWYVtFgjLaIG3dE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772707007; c=relaxed/simple; bh=Kg9h/ro8lGffnNHyMgj022euDS9qY3wSWFLp6tgSu7M=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=R714lCInl4zhKxeGn+OYNfZNvAMBydmOLV/Dvr8TNUXStqtoyeE5WsqpYcb5ncLrJay/gJWroLGL2SzPFYnkV6ZS87Z2Vl1Q7KA9bGk4FCBrJuTsYhRAgZjOEusKzaGyJ37QH+Cx8TiYvtOmIw1BTSwlgW9pChU20Oq9yiVlHbo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JSq55xL9; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=qDQzW971; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JSq55xL9"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="qDQzW971" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772707004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z1viVMpYgGTQrPss+rjXxyu4iRV/r/TC02JqQH3k0TE=; b=JSq55xL9+3qQtvcca0BcP4VPJ9wvURU6nlDNcd02XdpO1nSB326GBLhj4CnnSxSqQRxMuO 6UTVjgYVH6quhOc5kb2G+tQM96HgyY9rsSdvPmiC+W6dEDcB+2SYI4pDhDef6ng09P2IL/ VZrq+Fs8RWIkGGuth4lSCP7hvbS9s2E= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-A7I3begJOr-dwCuPHF_NzA-1; Thu, 05 Mar 2026 05:36:43 -0500 X-MC-Unique: A7I3begJOr-dwCuPHF_NzA-1 X-Mimecast-MFC-AGG-ID: A7I3begJOr-dwCuPHF_NzA_1772707002 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4806b12ad3fso67042875e9.0 for ; Thu, 05 Mar 2026 02:36:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772707002; x=1773311802; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=Z1viVMpYgGTQrPss+rjXxyu4iRV/r/TC02JqQH3k0TE=; b=qDQzW971S7tgSZdKrmm9I9/ORy5dEE/y29L9R0hSxDDp+x1+m2x258HUfeZWTZVKdu 7JDzws/Hct/sAFlJJLtmBJr+w5/CI8LOtK+ydRwK6SQhrUL70blKTTM3fxMtqmZKJIJP f2iz8KRLasLQCqJ3xFsg9zdTddp6+s46AWbkUVYMB0QJpE4LR2Or9d1YMzNwImsvbDv9 DTkvnPg53pasOqnjzXvPhX30QpqF06Da3RrbYAHAZ85heXivpLfprrxiRx0SmWUQYNSs dmGYOHWJ4lh2qNDFjo9oV/oPvobEWj1FmVbtsC5Hg83eBWgo7GU8xMgAtEBjyJ+ZeGhX o9JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772707002; x=1773311802; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z1viVMpYgGTQrPss+rjXxyu4iRV/r/TC02JqQH3k0TE=; b=QQ1SA3Xzpjg3hd1UlPpRkbOABUMilXoAosjbA0XMA/lmHwbMyA9jdotsHlv+aawlpx ZIZ0erEiaEWbUlvaKNskFzLEz4+eaXFBWCWZCmplpZDI+QwU2UU5dAqxWgox95y1VLzl sW1edZ6BKcFYTC5CjuY0RMLsQyZUDcp3jr6swoxJOA/L2ViyIruVwg7EJJ0dV6oS9SeX W/u62U1fIdK0LbAL6sJiERhZH2V2Hv1LPYN8NkOKq5TrTaHjzDXGfzVsTihv5eLTHgAh 6bygau042r/ty2/pqTPjMaI6Vd2J6elV8TDc2+wbnFTbvpQmAMMvk5L66hXalHeLGTGC JOiQ== X-Forwarded-Encrypted: i=1; AJvYcCWzNWhI/CE8L3QhcIfnEouN9/f2KqWeCbFLWV27OUnQefdYuDLCmFs20Lvz3gpJJbUx7/Sx5sNz4bAEuRQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyusvJCzZuXWlET7cgRiFAUTDU2dstD/Nq9AOCt3iZsVghGSzuv SJqHFKT8gI/DV4wJBXHjsZOZe9GtFrmKqMQupEBH9nOB9c2H9K8SDL+h5bd9qvcwSxpA1XTUdVS a7I9SsTP/OieXGGM/Ed1aeBGNKlGLwW1alb+PNEO1NaJxxnTT5Htc+8wOE+AUU2kw2Q== X-Gm-Gg: ATEYQzwXwEQlPhCwg+5ihRovgA0lwN9tVF9IpL0Teuzonoa4wob777Ov8CdlNGqO+LP 6fG4oYrLU9Aq4MKfFhSA9bRT0urDqPEPOzXSY08HMBsNHMhZuIcJaz6iSedFeggsADqLtXg6wMu Xohzu+7vGCgconOpflUP9G44ZHQ+NS1JgoHgqbQ5kemfvcnwEg/7W2Hx/HJ6z8SKqkO7n9Loz8W 8BjdmzXgRXIHdnWmx6a8TtQDtncH5T87ZmrfdJ65qbuyMcpK4oiIJZxyjS8mQ5ZmLpH+uH6jWQS qbRgx0aPJQhUfdQYoQkFiNxPlAgf183i/9fzt0U8C1hOWEELaNnqd2D/3KBl3FeUQubMa+ywpjW SY4UyZCnCpcQYjPKwJWtbZcjTBPAy8wZkBRQ6uceI1GtnsK+wh0VhesQQ83ChE54EF47iX0Jf/O jPvbz9 X-Received: by 2002:a05:600c:8b67:b0:480:2521:4d92 with SMTP id 5b1f17b1804b1-4851989ca05mr89009695e9.24.1772707002356; Thu, 05 Mar 2026 02:36:42 -0800 (PST) X-Received: by 2002:a05:600c:8b67:b0:480:2521:4d92 with SMTP id 5b1f17b1804b1-4851989ca05mr89009285e9.24.1772707001875; Thu, 05 Mar 2026 02:36:41 -0800 (PST) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851fb277e3sm32811255e9.10.2026.03.05.02.36.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 02:36:41 -0800 (PST) From: Javier Martinez Canillas To: David Lechner , David Lechner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Dmitry Baryshkov Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, David Lechner Subject: Re: [PATCH] drm/sitronix/st7586: fix bad pixel data due to byte swap In-Reply-To: <20260228-drm-mipi-dbi-fix-st7586-byte-swap-v1-1-e78f6c24cd28@baylibre.com> References: <20260228-drm-mipi-dbi-fix-st7586-byte-swap-v1-1-e78f6c24cd28@baylibre.com> Date: Thu, 05 Mar 2026 11:36:40 +0100 Message-ID: <87cy1iv9zb.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain David Lechner writes: > Correctly set dbi->write_memory_bpw for the ST7586 driver. This driver > is for a monochrome display that has an unusual data format, so the > default value set in mipi_dbi_spi_init() is not correct simply because > this controller is non-standard. > > Previously, we were using dbi->swap_bytes to make the same sort of > workaround, but it was removed in the same commit that added > dbi->write_memory_bpw, so we need to use the latter now to have the > correct behavior. > > This fixes every 3 columns of pixels being swapped on the display. There > are 3 pixels per byte, so the byte swap caused this effect. > > Fixes: df3fb27a74a4 ("drm/mipi-dbi: Make bits per word configurable for pixel transfers") > Signed-off-by: David Lechner > --- The patch looks good to me. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat