From: Andreas Hindborg <a.hindborg@kernel.org>
To: "Alice Ryhl" <aliceryhl@google.com>
Cc: "FUJITA Tomonori" <fujita.tomonori@gmail.com>,
<rust-for-linux@vger.kernel.org>, <boqun.feng@gmail.com>,
<frederic@kernel.org>, <lyude@redhat.com>, <tglx@linutronix.de>,
<anna-maria@linutronix.de>, <jstultz@google.com>,
<sboyd@kernel.org>, <ojeda@kernel.org>, <alex.gaynor@gmail.com>,
<gary@garyguo.net>, <bjorn3_gh@protonmail.com>,
<benno.lossin@proton.me>, <tmgross@umich.edu>,
<dakr@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/5] rust: time: Change Delta methods to take &self instead of self
Date: Mon, 02 Jun 2025 14:19:38 +0200 [thread overview]
Message-ID: <87cybm72ud.fsf@kernel.org> (raw)
In-Reply-To: <aD1fgizC4FPT07vt@google.com> (Alice Ryhl's message of "Mon, 02 Jun 2025 08:23:30 +0000")
"Alice Ryhl" <aliceryhl@google.com> writes:
> On Sun, May 04, 2025 at 01:59:54PM +0900, FUJITA Tomonori wrote:
>> Change several methods of the `Delta` type in Rust to take `&self`
>> instead of `self`. These methods do not mutate or consume the `Delta`
>> value and are more idiomatically expressed as taking a shared
>> reference. This change improves consistency with common Rust practice
>> and allows calling these methods on references without requiring an
>> explicit copy or move of the value.
>
> For small values that can be freely copied, I actualy think that using
> `self` is more common Rust practice.
Besides best practice, the value will pass in a register. There is no
benefit at all from passing a reference here and no improved ergonomics
from using a reference.
Best regards,
Andreas Hindborg
next prev parent reply other threads:[~2025-06-02 12:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-04 4:59 [PATCH v1 0/5] rust: time: Convert hrtimer to use Instant and Delta FUJITA Tomonori
2025-05-04 4:59 ` [PATCH v1 1/5] rust: time: Change Delta methods to take &self instead of self FUJITA Tomonori
2025-06-02 8:23 ` Alice Ryhl
2025-06-02 12:19 ` Andreas Hindborg [this message]
2025-06-03 13:31 ` FUJITA Tomonori
2025-05-04 4:59 ` [PATCH v1 2/5] rust: timer: Replace HrTimerMode enum with trait-based mode types FUJITA Tomonori
2025-06-02 12:53 ` Andreas Hindborg
2025-05-04 4:59 ` [PATCH v1 3/5] rust: time: Add HrTimerExpires trait FUJITA Tomonori
2025-05-30 13:04 ` Andreas Hindborg
2025-06-03 13:51 ` FUJITA Tomonori
2025-06-03 16:28 ` Andreas Hindborg
2025-05-04 4:59 ` [PATCH v1 4/5] rust: time: Make HasHrTimer generic over HrTimerMode FUJITA Tomonori
2025-06-02 12:41 ` Andreas Hindborg
2025-06-03 14:08 ` FUJITA Tomonori
2025-06-03 16:30 ` Andreas Hindborg
2025-05-04 4:59 ` [PATCH v1 5/5] rust: time: Remove Ktime in hrtimer FUJITA Tomonori
2025-06-02 12:41 ` Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cybm72ud.fsf@kernel.org \
--to=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=anna-maria@linutronix.de \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=frederic@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®