From: Jonathan Corbet <corbet@lwn.net>
To: Thorsten Blum <thorsten.blum@toblux.com>, mchehab@kernel.org
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
vegard.nossum@oracle.com,
Thorsten Blum <thorsten.blum@toblux.com>
Subject: Re: [PATCH v3] docs: scripts: sphinx-pre-install: Fix building docs with pyyaml package
Date: Wed, 14 Feb 2024 15:32:48 -0700 [thread overview]
Message-ID: <87cysyznfz.fsf@meer.lwn.net> (raw)
In-Reply-To: <20240208205550.984-1-thorsten.blum@toblux.com>
Thorsten Blum <thorsten.blum@toblux.com> writes:
> The Python module pyyaml is required to build the docs, but it is only
> listed in Documentation/sphinx/requirements.txt and is therefore missing
> when Sphinx is installed as a package and not via pip/pypi.
>
> Add pyyaml as an optional package for multiple distros to fix building the
> docs if you prefer to install Sphinx as a package.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
> Reviewed-by: Vegard Nossum <vegard.nossum@oracle.com>
> Tested-by: Vegard Nossum <vegard.nossum@oracle.com>
> ---
> Changes in v2:
> - s/pyyaml/yaml/ as suggested by Vegard Nossum
> - Make the check require the Python module; was optional
>
> Changes in v3:
> - Preserve Reviewed-by: and Tested-by: tags
> - Add pyyaml to openSUSE as suggested by Vegard Nossum
> ---
> scripts/sphinx-pre-install | 4 ++++
> 1 file changed, 4 insertions(+)
Applied, thanks.
jon
prev parent reply other threads:[~2024-02-14 22:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 11:12 [PATCH] " Thorsten Blum
2024-02-08 10:21 ` Vegard Nossum
2024-02-08 13:13 ` [PATCH v2] " Thorsten Blum
2024-02-08 16:37 ` Vegard Nossum
2024-02-08 20:15 ` Thorsten Blum
2024-02-08 20:55 ` [PATCH v3] " Thorsten Blum
2024-02-14 22:32 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cysyznfz.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=thorsten.blum@toblux.com \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®