From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04233C77B7A for ; Tue, 13 Jun 2023 11:21:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235122AbjFMLVU (ORCPT ); Tue, 13 Jun 2023 07:21:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242095AbjFMLJb (ORCPT ); Tue, 13 Jun 2023 07:09:31 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D68D210DA for ; Tue, 13 Jun 2023 04:09:25 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9238421F68; Tue, 13 Jun 2023 11:09:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686654564; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F534bER5ZYUKxtwTTojGuPlpYjHOsiKfFmO5iqx2CGc=; b=adfgtSfAfs2U65q67t2fCbt3EsyDXESujfIIPuiqYcPP31oQkLlVJoUtHjOCnkrXyOjjDR hvc9Wp5wzCtcD6+lW45c+LkKLphy7vL/09Z3+qekZGF6c5UIWbthDsFZRXbsQpdzD596Dq lEVb5dKtmCDLHJmDm28oU2gY2GcHNWo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686654564; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F534bER5ZYUKxtwTTojGuPlpYjHOsiKfFmO5iqx2CGc=; b=pXegNaIU+i2NUmFTLFD+SWQ1S8YmHPln5lve0fiUFLdvkTqz/tgga7MEUepaKOhc/t5hgy 25ugyfRYZ80sYBDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 708F713483; Tue, 13 Jun 2023 11:09:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id BLpwGmROiGQ5CQAAMHmgww (envelope-from ); Tue, 13 Jun 2023 11:09:24 +0000 Date: Tue, 13 Jun 2023 13:09:24 +0200 Message-ID: <87cz1zehzv.wl-tiwai@suse.de> From: Takashi Iwai To: Mark Brown Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH] regmap: maple: Don't sync read-only registers In-Reply-To: References: <20230613074511.4476-1-tiwai@suse.de> <87ilbrejlm.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Jun 2023 12:59:27 +0200, Mark Brown wrote: > > On Tue, Jun 13, 2023 at 12:34:45PM +0200, Takashi Iwai wrote: > > Mark Brown wrote: > > > On Tue, Jun 13, 2023 at 09:45:11AM +0200, Takashi Iwai wrote: > > > > This should be in _needs_sync(). > > > I thought it's a different logic? regacahe_reg_needs_sync() checks > > only whether it's a default value, and other call paths already check > > regmap_writeable(). > > Yeah, but it feels like that's the reason we ran into this issue given > that you'd expect _needs_sync() to check this too. > > > But I can put the check there instead if you still prefer, too. > > It should avoid any similar issues in future. OK, then let me cook the v2. Takashi