From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13568C433FE for ; Mon, 7 Nov 2022 09:45:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231736AbiKGJpL (ORCPT ); Mon, 7 Nov 2022 04:45:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231487AbiKGJpJ (ORCPT ); Mon, 7 Nov 2022 04:45:09 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A73955AC; Mon, 7 Nov 2022 01:45:06 -0800 (PST) From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1667814304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r8Z4Zi1uANBreU8pmHg5GxgTJ8KVuf0bPgW9y6lD8Pk=; b=ViMCNpcArCVmGhGZmToYhiU7CH8jdvYCPOCpKIjq5QfnEATVb3hQdDi6S6qTSV/2Kw7h+Q OdViPMuE4JxyXMipMIPWE0wYqLvjO7yEpyaV6TSYXuoPVSNadVko5LTquik1ZqtTUSTGEd bjX8YLv/q8upm4LydNdEMJx/ToubWtcSC/fqD+11Pe7DbXnv0Jt7WWw5507GQcem/MZPGh iXQeK/aXH61DFjN3NHbwJ+C/oGqZnPLPObtN6XaV6Jqv0JH63cwPz7Mc9sfIqE8Ozx/6Ll 122mw92La0GRrntkR+CZqv9o2zU4quvOENjMwrgpP8jXa5MtEEPoVMJwAlS3Lw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1667814304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r8Z4Zi1uANBreU8pmHg5GxgTJ8KVuf0bPgW9y6lD8Pk=; b=+pOpX581v8MitwoMCwXj5R0Idf95XwqAw037HFjQ/WUPsrAezfzKPtLPXf0dwnN5uD6lAc lV7uGAHBobKHaFAA== To: Petr Mladek Cc: Doug Anderson , Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org, Jason Wessel , Daniel Thompson , Greg Kroah-Hartman , Jiri Slaby , kgdb-bugreport@lists.sourceforge.net, linux-serial@vger.kernel.org Subject: Re: [PATCH printk v2 12/38] tty: serial: kgdboc: use console_is_enabled() In-Reply-To: References: <20221019145600.1282823-1-john.ogness@linutronix.de> <20221019145600.1282823-13-john.ogness@linutronix.de> <87czagf8hf.fsf@jogness.linutronix.de> <87bkpm7kp8.fsf@jogness.linutronix.de> Date: Mon, 07 Nov 2022 10:51:03 +0106 Message-ID: <87cz9z9jz4.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-11-07, Petr Mladek wrote: >> /* >> * Hold the console_lock to guarantee that no consoles are > ^^^^^^^^^^^^ >> * unregistered until the kgdboc_earlycon setup is complete. > > My understanding is that this is synchronized by console_list_lock. > Or do I miss something? Yes, in the end the comment will say console_list_lock. At this point in the series, the console_lock is still used. The comment is updated later (as in patch 34 of the v2 series). John