From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E511C433DF for ; Thu, 2 Jul 2020 00:52:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32B5F20780 for ; Thu, 2 Jul 2020 00:52:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727027AbgGBAwS (ORCPT ); Wed, 1 Jul 2020 20:52:18 -0400 Received: from relmlor2.renesas.com ([210.160.252.172]:44777 "EHLO relmlie6.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726388AbgGBAwS (ORCPT ); Wed, 1 Jul 2020 20:52:18 -0400 Date: 02 Jul 2020 09:52:17 +0900 X-IronPort-AV: E=Sophos;i="5.75,302,1589209200"; d="scan'208";a="50880523" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie6.idc.renesas.com with ESMTP; 02 Jul 2020 09:52:17 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id D4FCE400C09E; Thu, 2 Jul 2020 09:52:16 +0900 (JST) Message-ID: <87d05ezqlc.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Sameer Pujar Cc: , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v4 15/23] ASoC: soc-core: Identify 'no_pcm' DAI links for DPCM In-Reply-To: <9c7871ae-6649-7b0d-4780-c8389c299b04@nvidia.com> References: <1593233625-14961-1-git-send-email-spujar@nvidia.com> <1593233625-14961-16-git-send-email-spujar@nvidia.com> <87h7utytlx.wl-kuninori.morimoto.gx@renesas.com> <9c7871ae-6649-7b0d-4780-c8389c299b04@nvidia.com> User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sameer > > At least my CPU driver doesn't use component:pcm_construct > > but is using DAI:pcm_new for some reasons. > > I'm not sure checking DAI:pcm here is enough, or not... > > OK. If adding DAI:pcm_new above here is not sufficient, then a flag > can be used to describe FE component? or is there a better > alternative? soc_component_is_pcm() is called from simple_dai_link_of_dpcm :: "FE" side. I wonder component->driver->non_legacy_dai_naming can't work for you ? Thank you for your help !! Best regards --- Kuninori Morimoto