From: NeilBrown <neil@brown.name>
To: hariprasath.elango@gmail.com, blogic@openwrt.org,
gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
HariPrasath Elango <hariprasath.elango@gmail.com>
Subject: Re: [PATCH] staging: mt7621-gpio: remove redundant owner assignments of drivers
Date: Wed, 21 Mar 2018 09:26:33 +1100 [thread overview]
Message-ID: <87d0zy8jty.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <20180320074558.7851-1-hariprasath.elango@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 986 bytes --]
On Tue, Mar 20 2018, hariprasath.elango@gmail.com wrote:
> From: HariPrasath Elango <hariprasath.elango@gmail.com>
>
> Remove the reduntant owner initialization from this platform driver as
> the platform_driver_register() takes care of it.
>
> Signed-off-by: HariPrasath Elango <hariprasath.elango@gmail.com>
> ---
> drivers/staging/mt7621-gpio/gpio-mt7621.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/mt7621-gpio/gpio-mt7621.c b/drivers/staging/mt7621-gpio/gpio-mt7621.c
> index 5c57abe..830d429 100644
> --- a/drivers/staging/mt7621-gpio/gpio-mt7621.c
> +++ b/drivers/staging/mt7621-gpio/gpio-mt7621.c
> @@ -339,7 +339,6 @@ static struct platform_driver mediatek_gpio_driver = {
> .probe = mediatek_gpio_probe,
> .driver = {
> .name = "mt7621_gpio",
> - .owner = THIS_MODULE,
> .of_match_table = mediatek_gpio_match,
> },
> };
> --
> 2.10.0.GIT
Reviewed-by: NeilBrown <neil@brown.name>
Thanks,
NeilBrown
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 169 bytes --]
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2018-03-20 22:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 7:45 hariprasath.elango
2018-03-20 22:26 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0zy8jty.fsf@notabene.neil.brown.name \
--to=neil@brown.name \
--cc=blogic@openwrt.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hariprasath.elango@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome