From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752327AbdKVL47 (ORCPT ); Wed, 22 Nov 2017 06:56:59 -0500 Received: from ozlabs.org ([103.22.144.67]:46549 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752044AbdKVL46 (ORCPT ); Wed, 22 Nov 2017 06:56:58 -0500 From: Michael Ellerman To: Josh Boyer , Sukadev Bhattiprolu Cc: Benjamin Herrenschmidt , Michael Neuling , hbabu@us.ibm.com, nicholas.piggin@gmail.com, linuxppc-dev list , "Linux-Kernel\@Vger. Kernel. Org" , "kernel-team\@fedoraproject.org" Subject: Re: [PATCH v3 10/18] powerpc/vas, nx-842: Define and use chip_to_vas_id() In-Reply-To: References: <1510107838-15181-1-git-send-email-sukadev@linux.vnet.ibm.com> <1510107838-15181-11-git-send-email-sukadev@linux.vnet.ibm.com> Date: Wed, 22 Nov 2017 22:56:56 +1100 Message-ID: <87d14a34s7.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Josh Boyer writes: > On Tue, Nov 7, 2017 at 9:23 PM, Sukadev Bhattiprolu > wrote: ... >> diff --git a/arch/powerpc/platforms/powernv/vas.c b/arch/powerpc/platforms/powernv/vas.c >> index abb7090..cd9a733 100644 >> --- a/arch/powerpc/platforms/powernv/vas.c >> +++ b/arch/powerpc/platforms/powernv/vas.c >> @@ -123,6 +123,17 @@ struct vas_instance *find_vas_instance(int vasid) >> return NULL; >> } >> >> +int chip_to_vas_id(int chipid) >> +{ >> + int cpu; >> + >> + for_each_possible_cpu(cpu) { >> + if (cpu_to_chip_id(cpu) == chipid) >> + return per_cpu(cpu_vas_id, cpu); >> + } >> + return -1; >> +} >> + > > Likely need an EXPORT_SYMBOL here? Yep. >> diff --git a/drivers/crypto/nx/nx-842-powernv.c b/drivers/crypto/nx/nx-842-powernv.c >> index 874ddf5..eb221ed 100644 >> --- a/drivers/crypto/nx/nx-842-powernv.c >> +++ b/drivers/crypto/nx/nx-842-powernv.c > > Did anyone test this driver built as a module with this commit included? Clearly not. I build allmodconfig: http://kisskb.ellerman.id.au/kisskb/buildresult/13207275/ Which was green. But that doesn't enable this driver because it depends on PPC_VAS, which depends on PPC_64K_PAGES, and allmodconfig chooses 4K pages because that's the default in Kconfig. I've added a config with allmodconfig + 64K pages to catch this in future: http://kisskb.ellerman.id.au/kisskb/buildresult/13213014/ And we should probably flip 64K pages to be the default for 64-bit Book3S as well, all contemporary CPUs are designed for it. cheers