From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0635C77B7C for ; Fri, 28 Apr 2023 12:25:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230169AbjD1MZt (ORCPT ); Fri, 28 Apr 2023 08:25:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230262AbjD1MZp (ORCPT ); Fri, 28 Apr 2023 08:25:45 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B639A524B for ; Fri, 28 Apr 2023 05:25:40 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5066ce4f490so14525809a12.2 for ; Fri, 28 Apr 2023 05:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682684739; x=1685276739; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JZaTVYj+7JHW5ogrU2gshDHZR4SGV9IAITO2F/xNkdE=; b=S09ujwy6aOa6ctTYPXwZoPuRqF36CQOsazZonATFMiCtuWUqgPKeTkzkXMlHuMRDwV fLyWqUdCI9LTy5qBVXnvUr9nsc1iUB70043XxxZExzigT7J8Q5IBgzamv6tF2kALgu1Y Yea9deTDF9RU3VYdjcs6b5Rjz461ikvTNh/RO1MsUPAASsf9MNnIjvxm5MHjXHO8mWd3 MpDfVvBEqhnqWnh/krHjWorg//QItjEdQCqnZZ+7NaRY3SFEK9fv0qHuNQP8oTu23hUq XRgPM+D1+VtGFF4UcvqEN3Z1pUWM0Gxg0ZN152oSurdgRNsePO4i9JsPUHjavQrMvg1Y Uwww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682684739; x=1685276739; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JZaTVYj+7JHW5ogrU2gshDHZR4SGV9IAITO2F/xNkdE=; b=FxTW8MixRPe6cAEMJRK0zmpHkDNtBVPTyX6wmwRRt7DIYkBL7bTTjgFX2Lg+ltoZQY JWZ/Un3s+tLdt2zELamBzbqUrQUyT7y6jJRhLZiaFtulAyvu7m55cidhZlo+BQ9U1Qq5 bVO66bWIC2bQOcUzV92csbW7YKiNbJkDBREht8e/ajQl1bVkF21pYlqrEdZK2nknIXpg mpFbnxCTTTN3Y89m/In1LPvdgE+4q+d8Y9zW1EQsmdWVEoOvQx0AU+KqUTlASfxIJGUz 2fAHvqG9Kzdl/4HF2EOabpXvDNBOsKckGTcdxwOOiKRK1uGNAfb1d9qTdS7H28ZvLYWk kbGg== X-Gm-Message-State: AC+VfDzjWT7fU7ScO6TmzocUq01MSqpjfVzrTm3WcYYZIqPvpQq36k2L cLEuyhyun/q7H+AkALLcxHARIw== X-Google-Smtp-Source: ACHHUZ5nE8CV6swtaa6RT8oWCahIZAfJUkO/1Goui9aA/rILn+31p0oddbno5lpzYsEOiXt4oKJLeg== X-Received: by 2002:a50:fb04:0:b0:506:be49:243a with SMTP id d4-20020a50fb04000000b00506be49243amr4117396edq.15.1682684739187; Fri, 28 Apr 2023 05:25:39 -0700 (PDT) Received: from [172.23.4.26] ([31.221.30.162]) by smtp.gmail.com with ESMTPSA id f7-20020a05640214c700b004fa380a14e7sm9102383edx.77.2023.04.28.05.25.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Apr 2023 05:25:38 -0700 (PDT) Message-ID: <87d16bb4-178a-2583-5338-d9e9674da6e9@linaro.org> Date: Fri, 28 Apr 2023 13:25:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 07/13] drm/msm/dpu: Add SM6350 support Content-Language: en-US To: Marijn Suijten Cc: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Krishna Manikandan , Will Deacon , Robin Murphy , Joerg Roedel , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, Konrad Dybcio References: <20230411-topic-straitlagoon_mdss-v2-0-5def73f50980@linaro.org> <20230411-topic-straitlagoon_mdss-v2-7-5def73f50980@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/27/23 16:48, Marijn Suijten wrote: > On 2023-04-27 17:37:42, Marijn Suijten wrote: >> On 2023-04-21 00:31:16, Konrad Dybcio wrote: >>> Add SM6350 support to the DPU1 driver to enable display output. >>> >>> Signed-off-by: Konrad Dybcio >>> Signed-off-by: Konrad Dybcio >> After addressing the comments from Dmitry (CURSOR0->DMA1 and >> CURSOR1->DMA2), this is: >> >> Reviewed-by: Marijn Suijten >> >> See below for some nits. > Actually found one glaring issue that might explain why INTF TE wasn't > working for you the other day! [...] >>> + .vbif = sm6350_vbif, >>> + .reg_dma_count = 1, >>> + .dma_cfg = &sm8250_regdma, >>> + .perf = &sm6350_perf_data, >>> + .mdss_irqs = BIT(MDP_SSPP_TOP0_INTR) | \ >>> + BIT(MDP_SSPP_TOP0_INTR2) | \ >>> + BIT(MDP_SSPP_TOP0_HIST_INTR) | \ >>> + BIT(MDP_INTF0_INTR) | \ >>> + BIT(MDP_INTF1_INTR) > For completeness I should've pointed out that you're missing > MDP_INTF1_TEAR_INTR here, likely resulting in INTF TE not working. > > - Marijn so it might have been this.. I'll retest, thanks! Konrad > >