From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751334AbdH3Ke7 convert rfc822-to-8bit (ORCPT ); Wed, 30 Aug 2017 06:34:59 -0400 Received: from foss.arm.com ([217.140.101.70]:42516 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751186AbdH3Ke6 (ORCPT ); Wed, 30 Aug 2017 06:34:58 -0400 From: Punit Agrawal To: Borislav Petkov Cc: "Rafael J . Wysocki" , linux-acpi@vger.kernel.org, lorenzo.pieralisi@arm.com, sudeep.holla@arm.com, linux-kernel@vger.kernel.org, James Morse Subject: Re: [PATCH v3] ACPI / APEI: Suppress message if HEST not present References: <20170829132020.31471-1-punit.agrawal@arm.com> <20170829150219.4gg3443phihudvbv@pd.tnic> Date: Wed, 30 Aug 2017 11:34:55 +0100 In-Reply-To: <20170829150219.4gg3443phihudvbv@pd.tnic> (Borislav Petkov's message of "Tue, 29 Aug 2017 17:32:02 +0200") Message-ID: <87d17dgx80.fsf@e105922-lin.cambridge.arm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Borislav Petkov writes: > On Tue, Aug 29, 2017 at 02:20:20PM +0100, Punit Agrawal wrote: >> According to the ACPI specification, firmware is not required to provide >> the Hardware Error Source Table (HEST). When HEST is not present, the >> following superfluous message is printed to the kernel boot log - >> >> [ 3.460067] GHES: HEST is not enabled! >> >> Extend hest_disable variable to track whether the firmware provides this >> table and if it is not present skip any log output. The existing >> behaviour is preserved in all other cases. >> >> Suggested-by: Borislav Petkov >> Signed-off-by: Punit Agrawal >> Cc: Borislav Petkov >> Cc: James Morse >> --- >> >> Changes in v3: >> * Grouped hest_disable status checking into a switch/case for clarity >> >> drivers/acpi/apei/ghes.c | 7 ++++++- >> drivers/acpi/apei/hest.c | 13 +++++++------ >> include/acpi/apei.h | 8 +++++++- >> 3 files changed, 20 insertions(+), 8 deletions(-) > > Reviewed-by: Borislav Petkov Thanks! Hopefully Rafael can pick the patch for the upcoming merge window. > > -- > Regards/Gruss, > Boris. > > SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)