From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751201AbdEaS1v (ORCPT ); Wed, 31 May 2017 14:27:51 -0400 Received: from anholt.net ([50.246.234.109]:38730 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751058AbdEaS1u (ORCPT ); Wed, 31 May 2017 14:27:50 -0400 From: Eric Anholt To: Arnd Bergmann , David Airlie Cc: Arnd Bergmann , Linus Walleij , Daniel Vetter , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drm/pl111: fix warnings without CONFIG_ARM_AMBA In-Reply-To: <20170524155020.1777369-1-arnd@arndb.de> References: <20170524155020.1777369-1-arnd@arndb.de> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Wed, 31 May 2017 11:27:39 -0700 Message-ID: <87d1ao3mqs.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Arnd Bergmann writes: > The driver is written in a way to enable compile-testing without CONFIG_ARM_AMBA, > but it just causes needless warnings: > > drivers/gpu/drm/pl111/pl111_drv.c:149:26: error: 'pl111_drm_driver' defined but not used [-Werror=unused-variable] > drivers/gpu/drm/pl111/pl111_drv.c:81:12: error: 'pl111_modeset_init' defined but not used [-Werror=unused-function] > > This unhides the probe/remove functions again and just leaves the driver > object as unused when CONFIG_ARM_AMBA is disabled, with a __maybe_unused > annotation to shut up the warning. > > Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111") > Signed-off-by: Arnd Bergmann Reviewed and merged. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlkvCxwACgkQtdYpNtH8 nui0Uw/8DJreXtD2e27pXIeSmOOnRjddlcB1/12M5RUI74iouZgx/0N8V+BH8Kad 16mx8xO71NbMMY+YURy1V77F+mfD4SWUnLiORL+GujnBeIwfz8ErFN3GGuQHHRv/ bCmRFuBB6vfW2vb/Qkjig0QJ+jPtUdgJSYBjaUcTok5IrlyxqGLR2rA5KgiP5m0/ uStbmQpdcNgquB6iblyAuRAQMbM7pqs6nUDK+TxzSW1P60nZzgIHX87blFz1bWHs wd9lkPZNBQxNdDjblHEH6oKcJiiNmnbVRAkSPl72Kez6gdGckofDF7wo67sO7I7m 85db9FHtDszatAnaMWZVJj53cW7bXeFi5DzhnCRAXNtVrp1nMstxfKb8FdTM42/G t+cJtD6/6b+7Tx9nj5hHW5xPtf1IjL/ZLGdFswq8YKPFrKI0hFN3LH+olGzMhj+m kcTtQYzmDlbA2LHB9g/aLken2iLvBIXH9ZBGsdx51TPOOxIIxVsFavoJjHGknQoj I0S1Ll8cvCvk5mqdqLYSNpS/o6Nfie6l+QxIPyL6/utSEmT44oP65CYCn/DFHo1U h8EKAfNGcsZ36U/SbdCCeP8ILpu9JRtmFwyO6Wty47HfnCfdyoxfQTldSLwRPH2p FA3mTNbILEBNLV884ohb81Az5ZroZWiCJ7aGxSSXAouRDGCwco0= =Ao4x -----END PGP SIGNATURE----- --=-=-=--