From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752397AbcJZFes (ORCPT ); Wed, 26 Oct 2016 01:34:48 -0400 Received: from ozlabs.org ([103.22.144.67]:41745 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751965AbcJZFer (ORCPT ); Wed, 26 Oct 2016 01:34:47 -0400 From: Michael Ellerman To: Ingo Molnar Cc: akpm@osdl.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, peterz@infradead.org, jgross@suse.com, mgorman@techsingularity.net, richard@nod.at, len.brown@intel.com, bp@suse.de, boris.ostrovsky@oracle.com, tim.c.chen@linux.intel.com, ak@linux.intel.com, jolsa@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] kernel/smp: Make the SMP boot message common on all arches In-Reply-To: <20161016070406.GA4211@gmail.com> References: <1476348920-15066-1-git-send-email-mpe@ellerman.id.au> <20161016070406.GA4211@gmail.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Wed, 26 Oct 2016 16:34:42 +1100 Message-ID: <87d1iny8p9.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ingo Molnar writes: > * Michael Ellerman wrote: >> @@ -564,8 +560,11 @@ void __init smp_init(void) >> cpu_up(cpu); >> } >> >> + num_nodes = num_online_nodes(); >> + pr_info("smp: Brought up %d node%s, %d CPUs\n", >> + num_nodes, (num_nodes > 1 ? "s" : ""), num_online_cpus()); > > No objections - but pedantry requires me to mention that while we are evolving > this code and changing the strings I think we should make the CPU announcement > CPU%s smart as well: an SMP kernel on a single CPU bootup will result in > num_online_cpus() == 1, right? Yeah that makes sense. I don't often boot any single CPU systems, but I tested with maxcpus=1 and it does look nicer: smp: Brought up 2 nodes, 1 CPU Will send a v2. cheers