From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932314AbcFOGtG (ORCPT ); Wed, 15 Jun 2016 02:49:06 -0400 Received: from anholt.net ([50.246.234.109]:50811 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932222AbcFOGtC (ORCPT ); Wed, 15 Jun 2016 02:49:02 -0400 From: Eric Anholt To: Catalin Marinas Cc: open list , Will Deacon , Gerd Hoffmann , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Subject: Re: [PATCH v2 4/9] arm64: Add platform selection for BCM2835. In-Reply-To: <20160610095633.GA14961@e104818-lin.cambridge.arm.com> References: <1464934708-24769-1-git-send-email-kraxel@redhat.com> <1464934708-24769-5-git-send-email-kraxel@redhat.com> <20160603112721.GC1128@e104818-lin.cambridge.arm.com> <87bn3gu3to.fsf@eliezer.anholt.net> <20160608091219.GA16322@e104818-lin.cambridge.arm.com> <87h9d1x59s.fsf@eliezer.anholt.net> <20160610095633.GA14961@e104818-lin.cambridge.arm.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 14 Jun 2016 23:48:54 -0700 Message-ID: <87d1njq755.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Catalin Marinas writes: > On Thu, Jun 09, 2016 at 05:21:35PM -0700, Eric Anholt wrote: >> Catalin Marinas writes: >> > On Sat, Jun 04, 2016 at 12:55:15PM -0700, Eric Anholt wrote: >> >> Catalin Marinas writes: >> >> > On Fri, Jun 03, 2016 at 08:18:23AM +0200, Gerd Hoffmann wrote: >> >> >> + This SoC is used in the Raspberry Pi 3 device. >> >> > >> >> > I thought we would just use ARCH_BCM, or is it too generic? >> >>=20 >> >> Consensus last time around seemed to be to drop adding ARCH_BCM, in >> >> favor of patch 1 of the series. >> > >> > I may have missed that discussion. My point was about consistency with >> > existing ARCH_* definitions in the arm64 Kconfig.platforms. I can see >> > why it's easier for you since some drivers are built based on >> > ARCH_BCM2835. Looking at drivers/clk/bcm/Makefile, there is an >> > inconsistent mix of CLK_BCM_* and ARCH_BCM_*. I would rather have a new >> > CLK_BCM2835 that's selected/enabled accordingly (maybe simply depending >> > on ARCH_BCM). >>=20 >> So I introduce a new ARCH_BCM here, that selects the just the 283x >> family's core drivers? That seems strange, but I'm willing if that's >> what you want. > > I'll leave this decision to the arm-soc guys. What I want to avoid is > another ARCH_BCM283[89] when some clock or other device changes in a > future revision of this board (RPi4?). I also don't want fine-grained > SoC configuration *within* the arch/arm64 Kconfigs but rather just a > family ARCH_* entry with selectable individual drivers based on the SoC > revision you target (in case you want to avoid single Image). > > We should in general try to give drivers their own Kconfig entries > separate from ARCH_* ones (with a "depend on ARCH_*" and default y if > you want it enabled). OK, we haven't added separate ARCH_BCM283* for the 3 chip revs so far, so I think what you want is actually the status quo, and we're in serious agreement. The name for the family just happens to be ARCH_BCM2835. Any chance we could get an ack on this? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJXYPpWAAoJELXWKTbR/J7ouIgP/jdFndPjbcEGHDcci4C/3n4R Q1kQ1/ci7MlsApV4xVAjC9s67Q6ZxoFG+sQ2rra4a1qUOg7EB7F21BoBs3EU//NP eeCoR9SeoSjw/tp47b2x94cJjE/tzskQWpVHbKxkeUqZPAaTt4kvd7mmBmCsqSo0 k98W3iAYWSWbNaryxqUdmsFm7AyEGFXzgIxd/3yUir1ANJ7VQHHf/rWkuozt9Wvq 91QYfkr2fZLHhroXMBqeOWi1WXZzjEHaODGFyJVtlNWn70Yp2ckuT6CadTcYGidf dG8Yh5muI8rapzAylWpCcfdrdFW7aSm8Uizc3iHdicNLsmypyXcjBdviVkvayH4i phDq1oTkwXmNZalm7CUuT3J3Gzzy8dfjLauUZ9RWXTWxJn/1plCNk7sbAFdRxT/x d3NBwnIkDo13zxgNkP8xtqKzjSB5JGd08THM0F/CFhMOMBqZvC8UueXNW5J7Mb7l sd0I8E0IB+VZAW9+clLu0u2o+ZRtS0pKxd6XVQoVsURBkxOhU+1dfuhFyAg/wMmX rq8mqFcgQxfbOyhr2SKTMmcPrga/F4flq9vCcZKrB33AaWk16+kl7/UeqszNlrMW zMy3s9aj4e3omoXEwbioIZbwvQXdG2G6c6sszJ+jpE/mDSASjKJIWithCusVbMJg 32ed7el/BpsTbdDy3XEo =EEXz -----END PGP SIGNATURE----- --=-=-=--