From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Pawel Moll <pawel.moll@arm.com>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH v2 4/4] dmaengine: pxa_dma: fix the maximum requestor line
Date: Sat, 20 Feb 2016 22:39:15 +0100 [thread overview]
Message-ID: <87d1rrxdrw.fsf@belgarion.home> (raw)
In-Reply-To: <1455569868-25017-4-git-send-email-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Mon, 15 Feb 2016 21:57:48 +0100")
Robert Jarzmik <robert.jarzmik@free.fr> writes:
> The current number of requestor lines is limited to 31. This was an
> error of a previous commit, as this number is platform dependent, and is
> actually :
> - for pxa25x: 40 requestor lines
> - for pxa27x: 75 requestor lines
> - for pxa3xx: 100 requestor lines
>
> The previous testing did not reveal the faulty constant as on pxa[23]xx
> platforms, only camera, MSL and USB are above requestor 32, and in these
> only the camera has a driver using dma.
>
> Fixes: e87ffbdf0697 ("dmaengine: pxa_dma: fix the no-requestor case")
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
> Since v1: change to #dma-requests the of property name
> default to 32 requestors and warn as suggested by Vinod
Hi Vinod,
Are you happy with this version ?
If so could you provide me your Acked-by please ?
Cheers.
--
Robert
next prev parent reply other threads:[~2016-02-20 21:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 20:57 [PATCH v2 1/4] dma: mmp_pdma: Add the #dma-requests DT property documentation Robert Jarzmik
2016-02-15 20:57 ` [PATCH v2 2/4] dmaengine: mmp-pdma: add number of requestors Robert Jarzmik
2016-02-23 17:45 ` Robert Jarzmik
2016-02-15 20:57 ` [PATCH v2 3/4] ARM: pxa: add the number of DMA requestor lines Robert Jarzmik
2016-02-15 20:57 ` [PATCH v2 4/4] dmaengine: pxa_dma: fix the maximum requestor line Robert Jarzmik
2016-02-20 21:39 ` Robert Jarzmik [this message]
2016-02-23 3:13 ` Vinod Koul
2016-02-23 7:13 ` Robert Jarzmik
2016-02-26 22:17 ` Robert Jarzmik
2016-02-18 14:38 ` [PATCH v2 1/4] dma: mmp_pdma: Add the #dma-requests DT property documentation Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1rrxdrw.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=haojian.zhuang@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome