From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933780AbcATHk0 (ORCPT ); Wed, 20 Jan 2016 02:40:26 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35509 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751785AbcATHkR (ORCPT ); Wed, 20 Jan 2016 02:40:17 -0500 From: Peter Korsgaard To: "Yang\, Wenyou" Cc: Lee Jones , Rob Herring , "Pawel Moll" , Mark Rutland , "Ian Campbell" , Kumar Gala , "devicetree\@vger.kernel.org" , "Krzysztof Kozlowski" , "Ferre\, Nicolas" , "linux-kernel\@vger.kernel.org" , Javier Martinez Canillas , "linux-arm-kernel\@lists.infradead.org" Subject: Re: [PATCH v5 1/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver References: <1452747845-2962-1-git-send-email-wenyou.yang@atmel.com> <1452747845-2962-2-git-send-email-wenyou.yang@atmel.com> <87pox41dy9.fsf@dell.be.48ers.dk> <8737tzz33h.fsf@dell.be.48ers.dk> Date: Wed, 20 Jan 2016 08:40:11 +0100 In-Reply-To: (Wenyou Yang's message of "Wed, 20 Jan 2016 07:26:56 +0000") Message-ID: <87d1swvgv8.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Yang," == Yang, Wenyou writes: Hi, >> But the charger driver can just as well do: >> >> dev_get_regmap(dev->parent); >> >> instead of: >> >> dev_get_drvdata(pdev->dev.parent)->regmap. > For regulator, it works use the core do dev_get_regmap(dev->parent), > but for charger, it need to export *act8945a. Why? Just like the regulator core does, your battery driver can do: dev_get_regmap(dev->parent); -- Venlig hilsen, Peter Korsgaard