From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752895AbbLRPJq (ORCPT ); Fri, 18 Dec 2015 10:09:46 -0500 Received: from mga03.intel.com ([134.134.136.65]:28336 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751925AbbLRPJp (ORCPT ); Fri, 18 Dec 2015 10:09:45 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,446,1444719600"; d="scan'208";a="620213693" From: Alexander Shishkin To: Peter Zijlstra Cc: Ingo Molnar , linux-kernel@vger.kernel.org, vince@deater.net, eranian@google.com, johannes@sipsolutions.net, Arnaldo Carvalho de Melo Subject: Re: [PATCH 2/7] perf: Generalize task_function_call()ers In-Reply-To: <20151218090129.GQ6373@twins.programming.kicks-ass.net> References: <1449138762-15194-1-git-send-email-alexander.shishkin@linux.intel.com> <1449138762-15194-3-git-send-email-alexander.shishkin@linux.intel.com> <20151203173431.GC3816@twins.programming.kicks-ass.net> <87vb88yjs6.fsf@ashishki-desk.ger.corp.intel.com> <20151208165700.GE6357@twins.programming.kicks-ass.net> <20151217134034.GM6373@twins.programming.kicks-ass.net> <87k2odb19x.fsf@ashishki-desk.ger.corp.intel.com> <20151217150732.GG6344@twins.programming.kicks-ass.net> <20151218090129.GQ6373@twins.programming.kicks-ass.net> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 18 Dec 2015 17:07:34 +0200 Message-ID: <87d1u3bxs9.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter Zijlstra writes: > @@ -2774,9 +2696,6 @@ static void perf_event_context_sched_in( > */ > cpu_ctx_sched_out(cpuctx, EVENT_FLEXIBLE); > > - if (ctx->nr_events) > - cpuctx->task_ctx = ctx; > - > perf_event_sched_in(cpuctx, cpuctx->task_ctx, task); This then should probably become perf_event_sched_in(cpuctx, ctx, task); otherwise task contexts just don't get scheduled any more. Regards, -- Alex