From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753790AbbJFPbg (ORCPT ); Tue, 6 Oct 2015 11:31:36 -0400 Received: from mail-la0-f42.google.com ([209.85.215.42]:33057 "EHLO mail-la0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753497AbbJFPbc (ORCPT ); Tue, 6 Oct 2015 11:31:32 -0400 From: Rasmus Villemoes To: Bart Van Assche Cc: Christoph Hellwig , Hannes Reinecke , "James E.J. Bottomley" , , Subject: Re: [PATCH 2/2] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k Organization: D03 References: <20151004080217.GA22816@infradead.org> <1444037200-14684-1-git-send-email-linux@rasmusvillemoes.dk> <1444037200-14684-3-git-send-email-linux@rasmusvillemoes.dk> <56128527.1000703@sandisk.com> X-Hashcash: 1:20:151006:linux-kernel@vger.kernel.org::C3LTzjZO0svhcUke:0000000000000000000000000000000000Vd7 X-Hashcash: 1:20:151006:jbottomley@odin.com::WiohX/8nR44JBkh1:00000000000000000000000000000000000000000020rs X-Hashcash: 1:20:151006:hch@infradead.org::MhwyVmqgYo5qZrxy:000000000000000000000000000000000000000000002hy1 X-Hashcash: 1:20:151006:hare@suse.de::TADeTyKNm/BIKuWf:000002tik X-Hashcash: 1:20:151006:bart.vanassche@sandisk.com::qfcxawqgAOYbGKfK:000000000000000000000000000000000005aTv X-Hashcash: 1:20:151006:linux-scsi@vger.kernel.org::WTLZA8+2xoTAjAB6:000000000000000000000000000000000005Q00 Date: Tue, 06 Oct 2015 17:31:29 +0200 In-Reply-To: <56128527.1000703@sandisk.com> (Bart Van Assche's message of "Mon, 5 Oct 2015 07:11:51 -0700") Message-ID: <87d1wsm2su.fsf@rasmusvillemoes.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 05 2015, Bart Van Assche wrote: > On 10/05/15 02:26, Rasmus Villemoes wrote: >> struct error_info { >> unsigned short code12; /* 0x0302 looks better than 0x03,0x02 */ >> - const char * text; >> + unsigned short size; >> }; > > Had you considered to use the type uint16_t instead of unsigned short ? > Yes, but I thought I'd keep it consistent with the other member. AFAIK, they're one and the same on all relevant arches. I actually think spelling it u16 for both members would make sense (for the code because it explicitly is meant to hold two bytes), but again I think that's better done as a trivial follow-up patch, if we really want to change this. Rasmus