mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Kan Liang <kan.liang@intel.com>
Cc: acme@kernel.org, jolsa@redhat.com, linux-kernel@vger.kernel.org,
	ak@linux.intel.com
Subject: Re: [PATCH V5 3/3] perf tool: check buildid for symoff
Date: Thu, 27 Nov 2014 11:05:32 +0900	[thread overview]
Message-ID: <87d289o0sz.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <1416844829-26945-3-git-send-email-kan.liang@intel.com> (Kan Liang's message of "Mon, 24 Nov 2014 11:00:29 -0500")

Hi Kan,

On Mon, 24 Nov 2014 11:00:29 -0500, Kan Liang wrote:
> From: Kan Liang <kan.liang@intel.com>
>
> symoff can support both same binaries and different binaries. However,
> the offset may be changed for different binaries. This patch checks the
> buildid of perf.data. If they are from different binaries, print a
> warning to notify the user.

Hmm.. I think that perf diff is supposed to compare performance between
different (i.e. modified) binaries.  So there's a little point to print
the warning IMHO - but I'm not insist it strongly..

Anyway, I think what we really need for the warning is different version
of same binary.  For example, if data file 1 has DSO A and B, and data
file 2 has DSO B and C, we should not consider they're different (unless
build-ids of B in data file 1 and 2 are different) since A and C won't
affect symoff comparision.

Thanks,
Namhyung

  parent reply	other threads:[~2014-11-27  2:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-24 16:00 [PATCH V5 1/3] perf tool: Add sort key symoff for perf diff Kan Liang
2014-11-24 16:00 ` [PATCH V5 2/3] perf tool: new function to compare build_ids Kan Liang
2014-11-24 16:00 ` [PATCH V5 3/3] perf tool: check buildid for symoff Kan Liang
2014-11-25 11:51   ` Jiri Olsa
2014-11-26 16:10     ` Liang, Kan
2014-11-28  9:43       ` Jiri Olsa
2014-11-25 12:21   ` Jiri Olsa
2014-11-25 17:19     ` Liang, Kan
2014-11-27  2:05   ` Namhyung Kim [this message]
2014-11-27 14:09     ` Liang, Kan
2014-11-28  9:49       ` Jiri Olsa
2014-11-28 16:43         ` Liang, Kan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d289o0sz.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®