From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751976AbaGaXiH (ORCPT <rfc822;w@1wt.eu>);
	Thu, 31 Jul 2014 19:38:07 -0400
Received: from lgeamrelo04.lge.com ([156.147.1.127]:54464 "EHLO
	lgeamrelo04.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750907AbaGaXiG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 31 Jul 2014 19:38:06 -0400
X-Original-SENDERIP: 10.177.220.181
X-Original-MAILFROM: namhyung@gmail.com
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Minchan Kim <minchan@kernel.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
        Namhyung Kim <namhyung.kim@lge.com>,
        LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
        David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH 1/2] perf tools: Ensure --symfs ends with '/'
References: <1406251908-8195-1-git-send-email-namhyung@kernel.org>
	<20140729050246.GC22707@bbox> <20140729123305.GO7831@kernel.org>
	<87ppgnhge3.fsf@sejong.aot.lge.com> <20140730151932.GS7831@kernel.org>
	<20140730205521.GU7831@kernel.org> <87ha1ygnn3.fsf@sejong.aot.lge.com>
	<20140731122621.GV7831@kernel.org>
Date: Fri, 01 Aug 2014 08:38:02 +0900
In-Reply-To: <20140731122621.GV7831@kernel.org> (Arnaldo Carvalho de Melo's
	message of "Thu, 31 Jul 2014 09:26:21 -0300")
Message-ID: <87d2clgkv9.fsf@sejong.aot.lge.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Arnaldo,

On Thu, 31 Jul 2014 09:26:21 -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jul 31, 2014 at 01:25:52PM +0900, Namhyung Kim escreveu:
>> Are you still against my approach - adding '/' at the end of the symfs
>> string itself?  It seems that mine is simpler and shorter.
>
> Yes, I am.
>
> We are not just concatenating two strings, we are joining two path
> components.
>
> I think it is more clear and elegant to do it as python os.path.join()
> does.

Then I think you also need to care about trailing and leading '/' in the
components so that, say, joining '/home/' and '/namhyung/' can result in
'/home/namhyung/' not '/home///namhyung/'.

Btw, it seems like python's os.path.join() just use latter if it's an
absolute path.

  $ python
  Python 2.7.3 (default, Jul 24 2012, 10:05:38) 
  [GCC 4.7.0 20120507 (Red Hat 4.7.0-5)] on linux2
  Type "help", "copyright", "credits" or "license" for more information.
  >>> import os.path
  >>> os.path.join('/home/', '/namhyung/')
  '/namhyung/'
  >>> 


Thanks,
Namhyung