From: Namhyung Kim <namhyung@gmail.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
jolsa@redhat.com, linux-kernel@vger.kernel.org,
acme@infradead.org, fweisbec@gmail.com
Subject: Re: [PATCH 9/9] perf, tools, record: Always allow to overide default period v2
Date: Mon, 09 Jun 2014 14:21:52 +0900 [thread overview]
Message-ID: <87d2eid5e7.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20140604165930.GH8876@tassilo.jf.intel.com> (Andi Kleen's message of "Wed, 4 Jun 2014 09:59:30 -0700")
On Wed, 4 Jun 2014 09:59:30 -0700, Andi Kleen wrote:
> I saw samples.
>
> Oh well we can just drop it. The only difference is that the
> event list cannot set a period then.
I tested with a downloaded event, and it does have samples. But the
frequency could not be changed even with your patch.
$ perf record -a -e uops_retired.all -F 4000 sleep 1
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.327 MB perf.data (~14281 samples) ]
$ perf evlist -F
cpu/uops_retired.all/: sample_freq=2000003
>
> It's as broken as before.
At least, it worked well for events don't have a default sample
freq/period which means all but tracepoint events. For tracepoint
events, it makes little sense to change the default so I decided not to
touch it.
But with your change, the downloaded events might have a default
freq/period setting now. So I'd like to make it right. I'll send a fix
for this right soon.
Thanks,
Namhyung
next prev parent reply other threads:[~2014-06-09 5:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 21:50 perf: Add support for full Intel event lists v5 Andi Kleen
2014-05-30 21:50 ` [PATCH 1/9] perf, tools: Add jsmn `jasmine' JSON parser v2 Andi Kleen
2014-05-30 21:50 ` [PATCH 2/9] perf, tools: Add support for text descriptions of events and alias add Andi Kleen
2014-06-09 4:57 ` Namhyung Kim
2014-06-09 16:52 ` Andi Kleen
2014-06-10 5:58 ` Namhyung Kim
2014-05-30 21:50 ` [PATCH 3/9] perf, tools: Add support for reading JSON event files v3 Andi Kleen
2014-05-30 21:50 ` [PATCH 4/9] perf, tools: Automatically look for event file name for cpu v2 Andi Kleen
2014-05-30 21:50 ` [PATCH 5/9] perf, tools: Add perf download to download event files v3 Andi Kleen
2014-05-30 21:50 ` [PATCH 6/9] perf, tools: Allow events with dot Andi Kleen
2014-05-30 21:50 ` [PATCH 7/9] perf, tools: Query terminal width and use in perf list Andi Kleen
2014-05-30 21:50 ` [PATCH 8/9] perf, tools, test: Add test case for alias and JSON parsing v2 Andi Kleen
2014-05-30 21:50 ` [PATCH 9/9] perf, tools, record: Always allow to overide default period v2 Andi Kleen
2014-06-04 15:33 ` Namhyung Kim
2014-06-04 16:59 ` Andi Kleen
2014-06-09 5:21 ` Namhyung Kim [this message]
2014-06-09 5:56 ` perf: Add support for full Intel event lists v5 Namhyung Kim
2014-06-09 18:01 ` Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2014-05-15 22:03 perf: Add support for full Intel event lists v4 Andi Kleen
2014-05-15 22:03 ` [PATCH 9/9] perf, tools, record: Always allow to overide default period v2 Andi Kleen
2014-05-12 22:51 perf: Add support for full Intel event lists v3 Andi Kleen
2014-05-12 22:51 ` [PATCH 9/9] perf, tools, record: Always allow to overide default period v2 Andi Kleen
2014-05-14 5:50 ` Namhyung Kim
2014-05-15 20:51 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2eid5e7.fsf@sejong.aot.lge.com \
--to=namhyung@gmail.com \
--cc=acme@infradead.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome