From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5940FC433F5 for ; Tue, 28 Sep 2021 14:41:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3666C610E6 for ; Tue, 28 Sep 2021 14:41:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241373AbhI1Omv (ORCPT ); Tue, 28 Sep 2021 10:42:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241270AbhI1Omt (ORCPT ); Tue, 28 Sep 2021 10:42:49 -0400 Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 703C4C06161C for ; Tue, 28 Sep 2021 07:41:10 -0700 (PDT) Received: by mail-io1-xd2a.google.com with SMTP id r75so27680899iod.7 for ; Tue, 28 Sep 2021 07:41:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1ZhaZG/tQlxzocEQfHY1+FVhcMM4RpIdjkL8eV4PXdU=; b=EaaYZoLQyJe7lvJ2ke7VRkgD6vuBZuvRMzI/kJLnPozn8pxop5b/6uoLDitG3KpJBJ vVxcIFJNQ4sbxvuv+djjfhyGk6yYoBm7LPKgkxxuNRvAbbZtpFWkK1/bjYd9xgDY4u2i xu0THGW7dpad+h27yHcQGfBvgxrHy3peFhgPx6oKDYV3Zn6ag83EIzJCgSB4vWvEjtNP Wk4omfWxlvjbwvoWDu+w1w8qvTo1CFAYzq+iwellg7sll8fm10PtJ+5/S+xv64b0mNmL WR21XV2jLhsOynlPRI4/USfxDlwfJAPD8GuE9OgECejqMc97A18Uy6LGX7ccS6pTAtGK hY0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1ZhaZG/tQlxzocEQfHY1+FVhcMM4RpIdjkL8eV4PXdU=; b=aYxCb0Relp7+hri+GUY8bKkbCwPssg3E1AsVNWL7padq2/HtuEB6CKwMj7wNMebTnA ZG7mGrLkjkpbT+s3ogVKOLojdgM//CLf7pM1E/NJjwS7ppZD1qy428DM3xGTsAKFE0at qdcglOe+k70bEIcv4yME4qu/3b6XWDdeeSpS1nDKGJ7XeCxkOI0HjKv9X4e7jmK9eHBZ tjjEot3RihsaJy0R53OrbsdI0n9bKhsk1xX6qUlHGvCCM0W4FPRfU64S3bOLS9zFWgQo ulUvjXsRoQCgubXuqm6eeJXq60CX98EOJXMDm0MQtzt7FtjJYj+Pki7GoJ2nsXsivFjK Uvmg== X-Gm-Message-State: AOAM530aA8N9Q95OrXll5aJoDdt8Bq3lKIEHx5lMoiMKc5JUo/nJ2Kkm Z9AiIHLpVCc0EvuuAOaw7YP+4w== X-Google-Smtp-Source: ABdhPJzzqH3iPkshxUx6/WFfh3BcxwrV5dAebi1fz4A563SllOxpOSqNgPD19EjcESLy3iq9PXXgeA== X-Received: by 2002:a02:5d45:: with SMTP id w66mr4952789jaa.82.1632840069746; Tue, 28 Sep 2021 07:41:09 -0700 (PDT) Received: from [192.168.1.30] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id 67sm10855624iou.4.2021.09.28.07.41.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Sep 2021 07:41:09 -0700 (PDT) Subject: Re: sched: Remove pointless preemption disable in sched_submit_work() To: Thomas Gleixner , LKML Cc: Peter Zijlstra , Ingo Molnar , Peter Oskolkov , Tejun Heo References: <87sfxoai2l.ffs@tglx> From: Jens Axboe Message-ID: <87d7b153-11a6-2f47-a5ed-abe10a294df3@kernel.dk> Date: Tue, 28 Sep 2021 08:41:08 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87sfxoai2l.ffs@tglx> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/28/21 8:30 AM, Thomas Gleixner wrote: > Neither wq_worker_sleeping() nor io_wq_worker_sleeping() require to be invoked > with preemption disabled: > > - The worker flag checks operations only need to be serialized against > the worker thread itself. > > - The accounting and worker pool operations are serialized with locks. > > which means that disabling preemption has neither a reason nor a > value. Remove it. Reviewed-by: Jens Axboe -- Jens Axboe