From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E2FC1CFED1 for ; Mon, 21 Oct 2024 07:12:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729494761; cv=none; b=iHRC4OTIBstohXQxDQ8NS8b4Sc9FV/Ljd4nWmRhWHn+XtqgG22zjPk2mXDFx7epQvOgnYzb7wpx0awV3mHU2TuV5mel0Lest1ta8tiK57beTxoPbhGWNEVv8yyOV3aEBea+vOgMf6o1xX8BvyCcmiF4Dn8DF5WTOoXavt+RAyLQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729494761; c=relaxed/simple; bh=9aDpa7RjA+h6i2nUaoWao6dou9uzm4bcQfuBBPRqXLA=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=uHD5ndiZpIheW896nQ3vyZWEzqqrxfuyDqjTCVhSJdC4h4Rpjvktz4nMsoafkM/XxegwWTxH6MIIB+l0BpkLdhg1aOTXcioceq9caNDR4jnbivy0SKwzTEQuPcvGiZgyBo4TwxNAfkpJASmXPAYq2lNLDBQX20JDoiXPPdxyrqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VY5stajY; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VY5stajY" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-43167ff0f91so20518805e9.1 for ; Mon, 21 Oct 2024 00:12:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729494756; x=1730099556; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=Qcm1v2bTZyXU4vDGpi0B+UhZSQuP815LX7k5XuMY/5U=; b=VY5stajY7jIaIkaYAuI9cGzyj5Qb/H1idLRExUkRH5AH9SzhbqOioQdcHBKrigXjAy rO8OGlnrsloBZjVpblKtyGz+SIr9K12ZmZvhTHNYM/VZIAnfCv8Hy6vjUnxS7SPaei3c +StORklBfXuBvTF0z2SthR3K0VN4PpGQa9SOpYkKOxktVeaiJDbVxlIGuT6J5oMIEVkj wezayA8gJfSbXj5DhUGU1MQZNudKKFumq3CfL0+KQOpXxsdcALagHHLPRrf5iUligZbB vOmmsZzmB7gtc5pT0C5PINr00RVfZjbNULwzUHTIiMM9QfT4Qr7AOQ9C0zVp4gdtLdvZ r1TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729494756; x=1730099556; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Qcm1v2bTZyXU4vDGpi0B+UhZSQuP815LX7k5XuMY/5U=; b=jln0WzggpRgJJoBMbRp4KwdqSuA6ANGm2QyMstR6Tjb07DH0SAMsUDuF8ex4HUwxvP osS3mlJbo46M4FaqbgulZwlaXt+KDfXnbKKjJ5Ww6536SmvfEJHv851MPswnixgqZp0D NfQIo6D7bM0Yj3Z6ryhnuNWwgn8D2XGetdLlFYgcI+OF+R12TXCRWxoFk+ybCQCtw6g1 sR7p4KXHesQGamNAfPcp2j1mGpmuJYKA5OQQkMR7p+K78+xRMKWmuY3q7OoO1kE/Fw9N 3oC2qnra/OsLVEbAfdkAhy8IHTuP3IFHZ3B8OWnTkmhef+aks5AEECqiMWrz/xgfOI0J DGsg== X-Forwarded-Encrypted: i=1; AJvYcCUs+t1ZIIQBQrrIP/EiOzvcZdd0vzLMbWWsdyVDMmvst4Wr2k/wtwvhPAdkLoSIx5S3mGyegb8ZyOvcaR4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxsao5gsVo7kuqCA0qi2c6nZFRljY0mWO6QXlKOKAQqNZMqkSrD zz2wny5ewR409FVXfj7LZo74V5UIcrddnVo62LfzO65nwEOkqiGptvxtUX3Lz9I= X-Google-Smtp-Source: AGHT+IGpl6JMnMrYtUkza0HWfuTecrkb9l67H3tR/tiZP3auPNJFcRmSnNiCcgftPVWXOFvAlvSm4A== X-Received: by 2002:a05:600c:3b05:b0:42c:b5f1:44ff with SMTP id 5b1f17b1804b1-43161686a4cmr87117595e9.24.1729494755999; Mon, 21 Oct 2024 00:12:35 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:3908:dea6:2ddd:be97? ([2a01:e0a:982:cbb0:3908:dea6:2ddd:be97]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4316f5cbe7dsm46527555e9.39.2024.10.21.00.12.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Oct 2024 00:12:35 -0700 (PDT) Message-ID: <87d7d767-2058-49e6-9f36-5a79d5b0b5b6@linaro.org> Date: Mon, 21 Oct 2024 09:12:36 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v2] drm/bridge: Fix assignment of the of_node of the parent to aux bridge To: Abel Vesa , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Johan Hovold , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20241018-drm-aux-bridge-mark-of-node-reused-v2-1-aeed1b445c7d@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20241018-drm-aux-bridge-mark-of-node-reused-v2-1-aeed1b445c7d@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18/10/2024 14:49, Abel Vesa wrote: > The assignment of the of_node to the aux bridge needs to mark the > of_node as reused as well, otherwise resource providers like pinctrl will > report a gpio as already requested by a different device when both pinconf > and gpios property are present. > Fix that by using the device_set_of_node_from_dev() helper instead. > > Fixes: 6914968a0b52 ("drm/bridge: properly refcount DT nodes in aux bridge drivers") > Cc: stable@vger.kernel.org # 6.8 > Cc: Dmitry Baryshkov > Signed-off-by: Abel Vesa > --- > Changes in v2: > - Re-worded commit to be more explicit of what it fixes, as Johan suggested > - Used device_set_of_node_from_dev() helper, as per Johan's suggestion > - Added Fixes tag and cc'ed stable > - Link to v1: https://lore.kernel.org/r/20241017-drm-aux-bridge-mark-of-node-reused-v1-1-7cd5702bb4f2@linaro.org > --- > drivers/gpu/drm/bridge/aux-bridge.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/aux-bridge.c b/drivers/gpu/drm/bridge/aux-bridge.c > index b29980f95379ec7af873ed6e0fb79a9abb663c7b..295e9d031e2dc86cbfd2a7350718fca181c99487 100644 > --- a/drivers/gpu/drm/bridge/aux-bridge.c > +++ b/drivers/gpu/drm/bridge/aux-bridge.c > @@ -58,9 +58,10 @@ int drm_aux_bridge_register(struct device *parent) > adev->id = ret; > adev->name = "aux_bridge"; > adev->dev.parent = parent; > - adev->dev.of_node = of_node_get(parent->of_node); > adev->dev.release = drm_aux_bridge_release; > > + device_set_of_node_from_dev(&adev->dev, parent); > + > ret = auxiliary_device_init(adev); > if (ret) { > ida_free(&drm_aux_bridge_ida, adev->id); > > --- > base-commit: d61a00525464bfc5fe92c6ad713350988e492b88 > change-id: 20241017-drm-aux-bridge-mark-of-node-reused-5c2ee740ff19 > > Best regards, Reviewed-by: Neil Armstrong