From: David Woodhouse <dwmw2@infradead.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-kbuild@vger.kernel.org
Cc: Sam Ravnborg <sam@ravnborg.org>,
Marek Vasut <marek.vasut@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-doc@vger.kernel.org, Jim Cromie <jim.cromie@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org,
Michal Marek <michal.lkml@markovi.net>,
Brian Norris <computersforpeace@gmail.com>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
Boris Brezillon <boris.brezillon@bootlin.com>
Subject: Re: [PATCH] kbuild: announce removal of SUBDIRS if used
Date: Fri, 23 Nov 2018 08:04:39 +0000 [thread overview]
Message-ID: <87d7d90bf8779a997b17c917680995abc455cf11.camel@infradead.org> (raw)
In-Reply-To: <1542726258-8418-1-git-send-email-yamada.masahiro@socionext.com>
[-- Attachment #1: Type: text/plain, Size: 1213 bytes --]
On Wed, 2018-11-21 at 00:04 +0900, Masahiro Yamada wrote:
> SUBDIRS has been kept as a backward compatibility since
> commit ("[PATCH] kbuild: external module support") in 2002.
>
> We do not need multiple ways to do the same thing, so I will remove
> SUBDIRS after the Linux 5.3 release. I cleaned up in-tree code, and
> updated the document so that nobody would try to use it.
>
> Meanwhile, display the following warning if SUBDIRS is used.
>
> Makefile:189: ================= WARNING ================
> Makefile:190: 'SUBDIRS' will be removed after Linux 5.3
> Makefile:191: Please use 'M=' or 'KBUILD_EXTMOD' instead
> Makefile:192: ==========================================
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
No, please don't do this. This is effectively a kernel←→user ABI.
The instructions for building a kernel module have been this, for
*ages*:
echo 'obj-m := mymod.o' > Makefile
make -C /lib/modules/`uname -r`/build SUBDIRS=`pwd`
People have muscle memory, they have it encoded into various of their
own makefiles and build scripts. Please don't make it stop working
unless there's actually a really good reason to do so.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5213 bytes --]
next prev parent reply other threads:[~2018-11-23 8:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 15:04 Masahiro Yamada
2018-11-20 15:09 ` Boris Brezillon
2018-11-20 16:25 ` Guenter Roeck
2018-11-23 5:03 ` Masahiro Yamada
2018-11-23 8:04 ` David Woodhouse [this message]
2018-11-23 10:51 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d7d90bf8779a997b17c917680995abc455cf11.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=corbet@lwn.net \
--cc=jim.cromie@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marek.vasut@gmail.com \
--cc=michal.lkml@markovi.net \
--cc=richard@nod.at \
--cc=sam@ravnborg.org \
--cc=wim@linux-watchdog.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®