From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753529AbdHKQTn (ORCPT ); Fri, 11 Aug 2017 12:19:43 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:20028 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752901AbdHKQTm (ORCPT ); Fri, 11 Aug 2017 12:19:42 -0400 Subject: Re: [v6 15/15] mm: debug for raw alloctor To: Michal Hocko Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, kasan-dev@googlegroups.com, borntraeger@de.ibm.com, heiko.carstens@de.ibm.com, davem@davemloft.net, willy@infradead.org, ard.biesheuvel@linaro.org, will.deacon@arm.com, catalin.marinas@arm.com, sam@ravnborg.org References: <1502138329-123460-1-git-send-email-pasha.tatashin@oracle.com> <1502138329-123460-16-git-send-email-pasha.tatashin@oracle.com> <20170811130831.GN30811@dhcp22.suse.cz> From: Pasha Tatashin Message-ID: <87d84cad-f03a-88f0-7828-6d3bf7ac473c@oracle.com> Date: Fri, 11 Aug 2017 12:18:24 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170811130831.GN30811@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> When CONFIG_DEBUG_VM is enabled, this patch sets all the memory that is >> returned by memblock_virt_alloc_try_nid_raw() to ones to ensure that no >> places excpect zeroed memory. > > Please fold this into the patch which introduces > memblock_virt_alloc_try_nid_raw. OK I am not sure CONFIG_DEBUG_VM is the > best config because that tends to be enabled quite often. Maybe > CONFIG_MEMBLOCK_DEBUG? Or even make it kernel command line parameter? > Initially, I did not want to make it CONFIG_MEMBLOCK_DEBUG because we really benefit from this debugging code when VM debug is enabled, and especially struct page debugging asserts which also depend on CONFIG_DEBUG_VM. However, now thinking about it, I will change it to CONFIG_MEMBLOCK_DEBUG, and let users decide what other debugging configs need to be enabled, as this is also OK. Thank you, Pasha