From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755699AbeARRxm (ORCPT ); Thu, 18 Jan 2018 12:53:42 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:56552 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755618AbeARRxi (ORCPT ); Thu, 18 Jan 2018 12:53:38 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20180118175336euoutp0189b19e03da21eaebf660e855029b0b91~K_QMXn5sH2583925839euoutp019 X-AuditID: cbfec7f2-f793b6d000003243-9d-5a60df1f039e Subject: Re: [PATCH] crypto: mxs-dcp: Add empty hash export and import From: Kamil Konieczny To: Herbert Xu Cc: Marek Vasut , "David S. Miller" , Bartlomiej Zolnierkiewicz , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Message-id: <87da7572-a9a1-3fd1-e916-0cd5b161cfda@partner.samsung.com> Date: Thu, 18 Jan 2018 18:53:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-version: 1.0 In-reply-to: <4f3389a1-d6aa-b3cc-2299-d638058ddd48@partner.samsung.com> Content-type: text/plain; charset="utf-8" Content-language: en-US Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprOKsWRmVeSWpSXmKPExsWy7djPc7ry9xOiDC4eFbTYOGM9q8Wc8y0s Ft2vZCzu3/vJZHF51xw2izdtjYwObB5bVt5k8pg36wSLx7YDqh59W1YxenzeJBfAGsVlk5Ka k1mWWqRvl8CV8W7yS5aCDt6KI7PkGxi3c3UxcnJICJhIXLrbwAJhi0lcuLeerYuRi0NIYCmj xJetz1ghnM+MEm3dG9m7GDnAOpatc4KIL2OUaJi4kgnCecYocePTdBaQImEBN4nvR9lAprIJ mEs82n6GCcQWEdCRWPlyMdhQZoF9jBJXLj9hB0nwAtVP+N4KVsQioCox8dBfVhBbVCBCouvZ LlaIGkGJH5PvgZ3KKeAu8fFDC5jNLKAp8eLLJChbXKK59SaULS+xec1bZpBlEgIn2CR+fTnA DPGni8TD1m1QPwtLvDq+hR3ClpG4PLmbBaKhn1Fi+Y1T7BDOFEaJ49OuMkFUWUscPn6RFWIF n8SkbdOZIeHCK9HRJgRR4iHx6OcENgjbUaJ1Zws0iGYxShw6tJVxAqP8LCQfzULyxSwkX8xC 8sUCRpZVjCKppcW56anFxnrFibnFpXnpesn5uZsYgcnl9L/jn3Ywfj1hdYhRgINRiYd3w+KE KCHWxLLiytxDjBIczEoivO+8gUK8KYmVValF+fFFpTmpxYcYpTlYlMR5baPaIoUE0hNLUrNT UwtSi2CyTBycUg2M2mrnXwTev3dAf9H0Mt6cyez97ZFnjmRsuBIZcUVMQe4Nk4DytnJ1tasl m/5tvP3p8O17NcdqTl8K7j9QtDnXek1Ka0SPYL6F1WF2xsCJBV+nse1v+XdNfN3Sc4cv69eW fnB6VMMwg3ctT1eCYrRWc7pk4PKOSYtnngj+NPeuV760iOlP1Vh+JZbijERDLeai4kQAxMtm 9SoDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOLMWRmVeSWpSXmKPExsVy+t/xq7py9xOiDL79UrfYOGM9q8Wc8y0s Ft2vZCzu3/vJZHF51xw2izdtjYwObB5bVt5k8pg36wSLx7YDqh59W1YxenzeJBfAGsVlk5Ka k1mWWqRvl8CV8W7yS5aCDt6KI7PkGxi3c3UxcnBICJhILFvn1MXICWSKSVy4t56ti5GLQ0hg CaPEj5XXmSCcZ4wS3Rv3M4I0CAu4SXw/ygbSwCZgLvFo+xkmEFtEQEdi5cvFrCA2s8A+Rol5 95VBbCGBOYwSWyYEg9i8QK0TvreC1bMIqEpMPPQXrF5UIEKiaeZcVogaQYkfk++xgNicAu4S Hz+0sICsZRZQl5gyJRdivLhEc+tNFghbXmLzmrfMExgFZyHpnoXQMQtJxywkHQsYWVYxiqSW Fuem5xYb6RUn5haX5qXrJefnbmIEBv+2Yz+37GDsehd8iFGAg1GJh3fD4oQoIdbEsuLK3EOM EhzMSiK877yBQrwpiZVVqUX58UWlOanFhxilOViUxHl796yOFBJITyxJzU5NLUgtgskycXBK NTAeM0w94Se0oGObTkSwUsamG1eF4wNS7t5KOFHzI+N66p08xj+G8iEeh57GT/78u2TbbZal avoZp/QChKJVEnw+bp0ac3Xlz6SghSkvg7037E2T2vzh7TVj3rzn+uptJpMurVjgdu6zIdvU nT/PGzedfijI3v5M55FMTIZ810ohjecHXIxyps1RYinOSDTUYi4qTgQA9oVlhnoCAAA= X-CMS-MailID: 20180118175334eucas1p2e230ed2914e9eedf0113003553f70aae X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180116161641eucas1p1f776ccf0d08da2d3b670e5b2ad550ea6 X-RootMTR: 20180116161641eucas1p1f776ccf0d08da2d3b670e5b2ad550ea6 References: <4f3389a1-d6aa-b3cc-2299-d638058ddd48@partner.samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please drop this as I will resend it as part of patchset. On 16.01.2018 17:16, Kamil Konieczny wrote: > Crypto framework will require async hash export/import, so add empty > functions to prevent OOPS. > > Signed-off-by: Kamil Konieczny > --- > drivers/crypto/mxs-dcp.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/crypto/mxs-dcp.c b/drivers/crypto/mxs-dcp.c > index 764be3e6933c..a10c418d4e5c 100644 > --- a/drivers/crypto/mxs-dcp.c > +++ b/drivers/crypto/mxs-dcp.c > @@ -759,6 +759,16 @@ static int dcp_sha_digest(struct ahash_request *req) > return dcp_sha_finup(req); > } > > +static int dcp_sha_noimport(struct ahash_request *req, const void *in) > +{ > + return -ENOSYS; > +} > + > +static int dcp_sha_noexport(struct ahash_request *req, void *out) > +{ > + return -ENOSYS; > +} > + > static int dcp_sha_cra_init(struct crypto_tfm *tfm) > { > crypto_ahash_set_reqsize(__crypto_ahash_cast(tfm), > @@ -829,6 +839,8 @@ static struct ahash_alg dcp_sha1_alg = { > .final = dcp_sha_final, > .finup = dcp_sha_finup, > .digest = dcp_sha_digest, > + .import = dcp_sha_noimport, > + .export = dcp_sha_noexport, > .halg = { > .digestsize = SHA1_DIGEST_SIZE, > .base = { > @@ -853,6 +865,8 @@ static struct ahash_alg dcp_sha256_alg = { > .final = dcp_sha_final, > .finup = dcp_sha_finup, > .digest = dcp_sha_digest, > + .import = dcp_sha_noimport, > + .export = dcp_sha_noexport, > .halg = { > .digestsize = SHA256_DIGEST_SIZE, > .base = { > -- Best regards, Kamil Konieczny Samsung R&D Institute Poland