From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9D3D35F5E0 for ; Fri, 22 May 2026 05:57:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779429474; cv=none; b=tBW0oHMo2TxQHgBXld8WVBILhMqr3g//q3/HgknnQwKVzA1bxS1lUecCxvRib/iUeTb368dxMAeu+GOuVdgq4npObLxcV1cl/IPTFW1lJI/Fn8M3NPZnNKXL+Y/PzAkiCTqt25c26P1x7/6M2R3bgANAqNB8e8s13hPnWPTqEgg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779429474; c=relaxed/simple; bh=hJhn/eLEY2sTvwCziztqRUu5YYH7/pvQ2MtAlR51IiY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i0lKR6q7fC1qHPt1vdCZYmOpl0c5N9YYlX7+/KPzXU2NSqiOPoHP6x+uMy2PjMDhHQ3aHFOfy8SYQpT/q0418u4PKNABoOpK/f3/3nT0+pQQcrZIAwe5M+7na5HEbw01EVQt0tQAnU1igWaToj4Z/dBKOwfqWhEE5ib44+HSP0g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mdot7CP+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GL5L7Hng; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mdot7CP+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GL5L7Hng" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64M30LRv2765446 for ; Fri, 22 May 2026 05:57:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /runryRip9TcHkyLieUmStSMwcicxsH5P3t77krCWL8=; b=mdot7CP+oD2Pb59+ nG3KRtJQhQDQ7FmOF/yjKmmKG7zLn5TBu5cBggYX/CsssERPFoSKLqqlLJwDq+2e dBnLmrRGuMR4mZn5itadJvshhcE7klRIzRapCUKxnJzDKMoFHz/CReLaB+89xAem EwBzctWLzArezM22Mpwlrly3k+e7ed/Bz+OaDu5Z7B8dhXmNR3L/FL898n5TSEWo 14EUZ1ZfiXD6eSX7kNaHGduhYdkbHL4GLZ6P19BYeAmihAMr9E9XdYog+RZHGraf O2h0I5uoJzHptn6CeyxKI13D66xJZeXcW1+gzISsGXCzc0uCVDdFX0e3MrdxMpO0 XWm7kg== Received: from mail-dl1-f69.google.com (mail-dl1-f69.google.com [74.125.82.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ea3u7u9qt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 05:57:51 +0000 (GMT) Received: by mail-dl1-f69.google.com with SMTP id a92af1059eb24-132d631edaaso42594392c88.0 for ; Thu, 21 May 2026 22:57:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779429471; x=1780034271; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/runryRip9TcHkyLieUmStSMwcicxsH5P3t77krCWL8=; b=GL5L7Hngaca5Z4IDu2zB6K4ezPV/9kQ051GkUZpOmCp82n0N+9CEcKVrtpAgkfeeux MI7eTNV4Sp/jv93EPHfiF6UhLcefzTklIvdMem3lpsDfvtGxS0kEUKn2oKh8Yvvk72ug orFqbjYMMcgP0RAUoJrM2LE3qJe4rAy4p70fkTmjDNiYMER8LIiBRbSX+tqutDyxsfwB 144bFU8CRecL2orsPfB0NYYnUNQ/pCkf4njqVGnKY9nJ3R5wQElYg96E0oHSdZc4lD9K ggg2C3RvaVyvs0gCsFtFXZ6vbyTeW40Y9g/PyQQ74T1AnupaNybv+rXyvYQbUo1OZeYr cPEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779429471; x=1780034271; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/runryRip9TcHkyLieUmStSMwcicxsH5P3t77krCWL8=; b=fQJn1CRFg6Gcuf6gSnmSsjdqbPlXxgMTh1LaTla5TqOR3yoW2NiPVpwE4JC+AeGA9m 2FeKwjLlVw6NvkFyOrxjAOsskATiTuSuk7KGVwbo89EVs1DOkDKZkTm8U/Pwuj8CiCvR vegF497MOR06I8FR/EByzmeJFQNMNaqDiE+jjmixYlY0kg+wrigkQZdxzifPtXLBhws4 oIermS5A2AQ5N+VJgDN3gz4QxCU/jbWMMBILEBp2g75+fRGqmHLFp813vBXLHkd1Bt/a 4j0SJAoH8N/fQjOWwsPZH2FLvyyGtu5ukoDGVOcVlYu+ZKjBgXSGf3xmyu8EQXBnL4IQ L5Ww== X-Forwarded-Encrypted: i=1; AFNElJ83oS87VyDgk/fsch4J8oRop7QgzKBSp7lYiR2znieQ64KmBkHPPkFKQhylh6FzmVLmTssKnncl/YSyrII=@vger.kernel.org X-Gm-Message-State: AOJu0YxW4ESiOSoUu2Hi+lyQ+fF1o67ZU7zRs0cmIhlQ7CRGtUuh6E2X CAZo9BDBQwmCXHFuITUi50nE4/zN425LuuP9fbocsdauNNvhtCnPQX9CinoRbumQNCc78Z8rcSD Ioz7ypz+UoC6/ORgXAnsiNgOJNq0Ena9cC1nibXmZsiQ+jQV6GOhOJStKg/Z3BaigHe8= X-Gm-Gg: Acq92OGNwFTqmi2mVyyAXUTPkw1IeMEWoKZ1kGB8Ai1co9KLWZOf5U6CVLQ4/VFozPS 7dNW3lbWeEv5mdyajsFtc00HE7hCF1nLnETfS4/jm1RpPvCAhLrBgxYSAXHlX7Mk/JI5k6Mgmg/ 2dtallpeQ4EHy9WPJY0U35Aec/+d2Id/INWcy0utoVHfldLuTWDVraFHWN+VeC6tB2o27I3QIff uaejPR814i/MMmiY1oOdqASDnpVzxMC0DRuo/bagEwUCOroOQK81KE5cQHJirLgmHeVLQf/R5sV 35zKAhiJkaQLlwFQhd2b9VSaNFhCYE6am7/Y1eYrfdOxeMkvYQjOQIbNUHqXTTEJqhEflQQSCn8 o1gf1RD6bTCf583U1z10hbM4koeukoOjXjrC0lFLKgIVRpPFc6K4XTltNdGYTdRezVQy2L6PGoM IsFRjf X-Received: by 2002:a05:7301:6589:b0:2ed:e17:d50c with SMTP id 5a478bee46e88-304491fb381mr1175600eec.31.1779429470821; Thu, 21 May 2026 22:57:50 -0700 (PDT) X-Received: by 2002:a05:7301:6589:b0:2ed:e17:d50c with SMTP id 5a478bee46e88-304491fb381mr1175589eec.31.1779429470285; Thu, 21 May 2026 22:57:50 -0700 (PDT) Received: from [10.110.121.192] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30451f20e71sm268109eec.12.2026.05.21.22.57.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 May 2026 22:57:49 -0700 (PDT) Message-ID: <87dff78b-c075-48d7-83cb-810694617ba2@oss.qualcomm.com> Date: Fri, 22 May 2026 13:57:45 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/1] dm-inlinecrypt: add support for hardware-wrapped keys To: Milan Broz , Mikulas Patocka , Eric Biggers Cc: Alasdair Kergon , Mike Snitzer , Benjamin Marzinski , Neeraj Soni , dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260516115045.3958326-1-linlin.zhang@oss.qualcomm.com> <20260516115045.3958326-2-linlin.zhang@oss.qualcomm.com> <3b57685a-09b4-473a-8810-bbb46769ab42@gmail.com> <2712f864-0f68-4428-9ba5-55fbf35de6e8@oss.qualcomm.com> <98f9f0e3-964d-414c-a329-254c141c8d48@gmail.com> Content-Language: en-US From: Linlin Zhang In-Reply-To: <98f9f0e3-964d-414c-a329-254c141c8d48@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=aIXAb79m c=1 sm=1 tr=0 ts=6a0ff05f cx=c_pps a=kVLUcbK0zfr7ocalXnG1qA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=XU54WYprocpNAOCwec4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=vr4QvYf-bLy2KjpDp97w:22 X-Proofpoint-GUID: iVZfTA8ZElTxLHClOhyea73rvutHn2OQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDA1NyBTYWx0ZWRfXxCwlWg1JF27I FSjwSyiZ0O0yY8M4HG0c/UWC1D3OHh91F8XbbGfi6DrUSsmekY7OmZ2lZFgQSpoxOe7spDgkwfb IhOuwk7ql3bIkDww4Yo7A5vwMoqOrCNpAdnWik4WrRtMayq/EFLcAU2O19LBAryMVcfN1aFLYTB pfWnQGAUCY02tU2HldfskJQwSZeaMJVmt1pKP6MvFANp3UkozG6vay3AgFq/zB7MFjGiDDdn5AM k17nFds4Eo4nK5OMGJBb9hldUtEWR5hGO734U5VtwYlTQ6iw52mGZJdzxarid4ai4xyO8qtmGSZ 0q+6zkBFxx/YDayNjXKcIE2OUpEUTWpJomKFwf4o/ZTU4DqFa894JGH6JlNai3EDqNE2jLF5u/F I/mr2NT5/4dobL0RJylt5C8IK080klHBox6exLgGnOkJm8wmkmzuXqWvGTs7gUpTGG/cKWFIMRl uvdkCHJ7SSFMEMLdBEQ== X-Proofpoint-ORIG-GUID: iVZfTA8ZElTxLHClOhyea73rvutHn2OQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 spamscore=0 suspectscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220057 On 5/18/2026 8:49 PM, Milan Broz wrote: > On 5/18/26 10:11 AM, Linlin Zhang wrote: > > ... >>> IOW the mapping will look like this (1 is number of optional parameters): >>> >>>     1 hw-wrapped >>> or >>>     1 keytype=hw-wrapped >> >> >> Thanks for your suggestion! >> >> I agree that keeping "hw-wrapped" or "keytype=raw|hw-wrapped" as an optional >> argument helps preserve compatibility when switching from "crypt" to >> "inlinecrypt" > > Just use semicolon as separator as Mikulas suggested. > (I mixed that up, we always use semicolan as separator.) > >> My concern is that, in practice, this optional argument may effectively become >> mandatory for certain configurations. For instance, "hw-wrapped" or >> "keytype=raw|hw-wrapped" must be set for a wrapped key. This slightly blurs the >> original intent of "optional arguments", which are typically expected to be >> truly optional for correct operation. > > It no longer works this way, it is normal that in some scenarios "optional" arguments > are required. For example sector_size - once you use non-default, you have to specify > it always. > > IOW no problem with that. Thanks for the comments! ACK. I'll send a new patch with such modification. > > Milan >