mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Mihai Sain <mihai.sain@microchip.com>
Cc: mturquette@baylibre.com, sboyd@kernel.org,
	nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
	claudiu.beznea@tuxon.dev, varshini.rajendran@microchip.com,
	cristian.birsan@microchip.com,
	balamanikandan.gunasundar@microchip.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	ryan.wanner@microchip.com
Subject: Re: [PATCH 4/5] ARM: dts: microchip: sam9x7: Remove the tx_clk from gmac node
Date: Mon, 2 Feb 2026 14:59:20 +0100	[thread overview]
Message-ID: <87e0938c-20da-48bc-9bb7-8ca963800dae@lunn.ch> (raw)
In-Reply-To: <20260202104025.3781-5-mihai.sain@microchip.com>

On Mon, Feb 02, 2026 at 12:40:24PM +0200, Mihai Sain wrote:
> The gmac controller on sam9x7 has no internal pll to generate
> the 125MHz clock source for rgmii mode.
> This clock is generated on external board by eth-phy or
> clock oscillator.
> This change drops the tx_clk entry from gmac node.
> 
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
> ---
>  arch/arm/boot/dts/microchip/sam9x7.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/microchip/sam9x7.dtsi b/arch/arm/boot/dts/microchip/sam9x7.dtsi
> index 46dacbbd201d..da94865c57e9 100644
> --- a/arch/arm/boot/dts/microchip/sam9x7.dtsi
> +++ b/arch/arm/boot/dts/microchip/sam9x7.dtsi
> @@ -991,7 +991,7 @@ gmac: ethernet@f802c000 {
>  				     <63 IRQ_TYPE_LEVEL_HIGH 3>,	/* Queue 4 */
>  				     <64 IRQ_TYPE_LEVEL_HIGH 3>;	/* Queue 5 */
>  			clocks = <&pmc PMC_TYPE_PERIPHERAL 24>, <&pmc PMC_TYPE_PERIPHERAL 24>, <&pmc PMC_TYPE_GCK 24>, <&pmc PMC_TYPE_GCK 67>;
> -			clock-names = "hclk", "pclk", "tx_clk", "tsu_clk";
> +			clock-names = "hclk", "pclk", "tsu_clk";

You drop a clock name, but not a clock?

    Andrew

  reply	other threads:[~2026-02-02 13:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02 10:40 [PATCH 0/5] Update gmac clocks and devicetree for sam9x7 mpu Mihai Sain
2026-02-02 10:40 ` [PATCH 1/5] clk: at91: sam9x7: Remove gmac peripheral and generic clock entries with ID 67 Mihai Sain
2026-02-02 13:55   ` Andrew Lunn
2026-02-02 10:40 ` [PATCH 2/5] clk: at91: sam9x7: Rename macb0_clk to gmac_clk Mihai Sain
2026-02-02 10:40 ` [PATCH 3/5] clk: at91: sam9x7: Add gmac generic clock entry with ID 24 Mihai Sain
2026-02-02 10:40 ` [PATCH 4/5] ARM: dts: microchip: sam9x7: Remove the tx_clk from gmac node Mihai Sain
2026-02-02 13:59   ` Andrew Lunn [this message]
2026-02-02 10:40 ` [PATCH 5/5] ARM: dts: microchip: sam9x7: Update the tsu_clk to use the generic clock with ID 24 Mihai Sain
2026-02-02 14:00   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87e0938c-20da-48bc-9bb7-8ca963800dae@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=alexandre.belloni@bootlin.com \
    --cc=balamanikandan.gunasundar@microchip.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=conor+dt@kernel.org \
    --cc=cristian.birsan@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mihai.sain@microchip.com \
    --cc=mturquette@baylibre.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=robh@kernel.org \
    --cc=ryan.wanner@microchip.com \
    --cc=sboyd@kernel.org \
    --cc=varshini.rajendran@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®