From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE763C6FA83 for ; Tue, 13 Sep 2022 08:57:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231258AbiIMI5o (ORCPT ); Tue, 13 Sep 2022 04:57:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230400AbiIMI5m (ORCPT ); Tue, 13 Sep 2022 04:57:42 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E9E1F3DF1F for ; Tue, 13 Sep 2022 01:57:41 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1EB281063; Tue, 13 Sep 2022 01:57:48 -0700 (PDT) Received: from [10.162.42.9] (unknown [10.162.42.9]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9C5903F73B; Tue, 13 Sep 2022 01:57:39 -0700 (PDT) Message-ID: <87e3cb9c-c401-f18b-8d6a-dd63ed6c9e17@arm.com> Date: Tue, 13 Sep 2022 14:27:36 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 10/16] mm, memory_hotplug: remove obsolete generic_free_nodedata() Content-Language: en-US To: Miaohe Lin , akpm@linux-foundation.org Cc: david@redhat.com, osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220909092451.24883-1-linmiaohe@huawei.com> <20220909092451.24883-11-linmiaohe@huawei.com> From: Anshuman Khandual In-Reply-To: <20220909092451.24883-11-linmiaohe@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/9/22 14:54, Miaohe Lin wrote: > Commit 390511e1476e ("mm, memory_hotplug: drop arch_free_nodedata") > drops the last caller of generic_free_nodedata(). Remove it too. > > Signed-off-by: Miaohe Lin Reviewed-by: Anshuman Khandual > --- > include/linux/memory_hotplug.h | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h > index 51052969dbfe..9fcbf5706595 100644 > --- a/include/linux/memory_hotplug.h > +++ b/include/linux/memory_hotplug.h > @@ -43,11 +43,6 @@ extern void arch_refresh_nodedata(int nid, pg_data_t *pgdat); > ({ \ > memblock_alloc(sizeof(*pgdat), SMP_CACHE_BYTES); \ > }) > -/* > - * This definition is just for error path in node hotadd. > - * For node hotremove, we have to replace this. > - */ > -#define generic_free_nodedata(pgdat) kfree(pgdat) > > extern pg_data_t *node_data[]; > static inline void arch_refresh_nodedata(int nid, pg_data_t *pgdat) > @@ -63,9 +58,6 @@ static inline pg_data_t *generic_alloc_nodedata(int nid) > BUG(); > return NULL; > } > -static inline void generic_free_nodedata(pg_data_t *pgdat) > -{ > -} > static inline void arch_refresh_nodedata(int nid, pg_data_t *pgdat) > { > }