From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Nick Desaulniers <nick.desaulniers@gmail.com>
Cc: <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
<xen-devel@lists.xenproject.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [Xen-devel] [PATCH] x86/xen/time: fix section mismatch for xen_init_time_ops()
Date: Tue, 2 Jan 2018 14:32:17 +0000 [thread overview]
Message-ID: <87e3dc74-5959-1ecf-6854-fda017c2c775@citrix.com> (raw)
In-Reply-To: <d5314269-6d7e-d496-695f-af59bc41f554@suse.com>
On 02/01/18 14:24, Juergen Gross wrote:
> On 02/01/18 15:18, Boris Ostrovsky wrote:
>> On 12/23/2017 09:50 PM, Nick Desaulniers wrote:
>>> The header declares this function as __init but is defined in __ref
>>> section.
>>>
>>> Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
>> AFAIK section attributes in header files are ignored by compiler anyway
>> so I'd remove all of them.
> Hmm, I'm not sure all future compilers will ignore the section
> attributes. include/linux/init.h explictily mentions where to put
> the attrubute in a prototype, so I'd rather keep it.
Attributes in the declaration are for static analysis tools such as sparse.
How else are you going to work out whether a section mismatch has occurred?
~Andrew
next prev parent reply other threads:[~2018-01-02 14:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-24 2:50 Nick Desaulniers
2018-01-02 7:55 ` Juergen Gross
2018-01-02 14:18 ` Boris Ostrovsky
2018-01-02 14:24 ` Juergen Gross
2018-01-02 14:32 ` Andrew Cooper [this message]
2018-01-02 15:00 ` [Xen-devel] " Boris Ostrovsky
2018-01-06 20:35 ` Nick Desaulniers
2018-01-08 14:49 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87e3dc74-5959-1ecf-6854-fda017c2c775@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nick.desaulniers@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®