From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 248B4C761AF for ; Mon, 27 Mar 2023 13:25:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230208AbjC0NZu (ORCPT ); Mon, 27 Mar 2023 09:25:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232496AbjC0NZc (ORCPT ); Mon, 27 Mar 2023 09:25:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 336BB59FD; Mon, 27 Mar 2023 06:24:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 724676126E; Mon, 27 Mar 2023 13:24:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90AB3C433D2; Mon, 27 Mar 2023 13:23:56 +0000 (UTC) Message-ID: <87e68e05-8512-17fc-584c-0022ddefb8f0@linux-m68k.org> Date: Mon, 27 Mar 2023 23:23:53 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] arm64: dts: imx8mp: add vpu pgc nodes Content-Language: en-US To: Peng Fan , "Peng Fan (OSS)" Cc: "Markus.Niebel@ew.tq-group.com" , "aford173@gmail.com" , Aisheng Dong , "alexander.stein@ew.tq-group.com" , "devicetree@vger.kernel.org" , "festevam@gmail.com" , "kernel@pengutronix.de" , "krzysztof.kozlowski+dt@linaro.org" , "l.stach@pengutronix.de" , "laurent.pinchart@ideasonboard.com" , "linux-arm-kernel@lists.infradead.org" , dl-linux-imx , "linux-kernel@vger.kernel.org" , "marex@denx.de" , "paul.elder@ideasonboard.com" , "robh+dt@kernel.org" , "s.hauer@pengutronix.de" , "shawnguo@kernel.org" , "gerg@kernel.org" References: <20220713063653.2584488-6-peng.fan@oss.nxp.com> <20230327050642.593778-1-gerg@linux-m68k.org> From: Greg Ungerer In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peng, On 27/3/23 20:01, Peng Fan wrote: >> Subject: Re: [PATCH] arm64: dts: imx8mp: add vpu pgc nodes >> >> On 22/8/22 14:45, Peng Fan wrote: >>> Add i.MX8MP PGC nodes for vpu, which are used to supply power for VPU. >>> >>> Signed-off-by: Peng Fan >>> Signed-off-by: Shawn Guo >>> --- >>> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 27 >>> +++++++++++++++++++++++ >>> 1 file changed, 27 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>> index 0b165f98a82c..34af983b0210 100644 >>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>> @@ -598,6 +598,33 @@ pgc_ispdwp: power-domain@18 { >>> reg = >> ; >>> clocks = <&clk IMX8MP_CLK_MEDIA_ISP_ROOT>; >>> }; >>> + >>> + pgc_vpumix: power-domain@19 { >>> + #power-domain-cells = <0>; >>> + reg = ; >>> + clocks =<&clk IMX8MP_CLK_VPU_ROOT>; >>> + }; >>> + >>> + pgc_vpu_g1: power-domain@20 { >>> + #power-domain-cells = <0>; >>> + power-domains = <&pgc_vpumix>; >>> + reg = ; >>> + clocks = <&clk IMX8MP_CLK_VPU_G1_ROOT>; >>> + }; >>> + >>> + pgc_vpu_g2: power-domain@21 { >>> + #power-domain-cells = <0>; >>> + power-domains = <&pgc_vpumix>; >>> + reg = ; >>> + clocks = <&clk IMX8MP_CLK_VPU_G2_ROOT>; >>> + }; >>> + >>> + pgc_vpu_vc8000e: power-domain@22 { >>> + #power-domain-cells = <0>; >>> + power-domains = <&pgc_vpumix>; >>> + reg = >> ; >>> + clocks = <&clk >> IMX8MP_CLK_VPU_VC8KE_ROOT>; >>> + }; >>> }; >>> }; >>> }; >> >> This change causes new error messages to come out during boot, for >> example: >> >> ... >> imx-pgc imx-pgc-domain.8: failed to command PGC >> imx-pgc imx-pgc-domain.8: failed to command PGC >> imx-pgc imx-pgc-domain.8: failed to command PGC >> 30890000.serial: ttymxc1 at MMIO 0x30890000 (irq = 197, base_baud = >> 1500000) is a IMX >> ... >> hwmon hwmon1: temp1_input not attached to any thermal zone >> imx-pgc imx-pgc-domain.8: failed to command PGC >> imx-pgc imx-pgc-domain.8: failed to command PGC >> imx-pgc imx-pgc-domain.8: failed to command PGC >> ... >> >> They don't seem to cause any problems on the hardware I am using, well, at >> least not that I have found so far. >> >> This first appeared for me in linux-6.1. But it is the same in todays linux 6.3- >> rc4. Reverting this change (not completely trivial due to a couple of commits >> after it that rely on it) fixes it - no more errors. > [Peng Fan] > > The VPU BLK CTRL seems not enabled. How to enable it? I have the blk-ctrl config options enabled: # # i.MX SoC drivers # CONFIG_IMX_GPCV2_PM_DOMAINS=y CONFIG_SOC_IMX8M=y CONFIG_SOC_IMX9=y CONFIG_IMX8M_BLK_CTRL=y CONFIG_IMX9_BLK_CTRL=y # end of i.MX SoC drivers Running with the full arm64 defconfig and using the imx8mp-evk.dtb still outputs these messages: [ 18.150679] imx-pgc imx-pgc-domain.8: failed to command PGC [ 18.159241] imx-pgc imx-pgc-domain.8: failed to command PGC [ 18.167822] imx-pgc imx-pgc-domain.8: failed to command PGC Or do you mean something more fundamental, like the hardware block not being enabled by boot loader? (Something to keep in mind is that the platform I am using has no video output, only serial console). Regards Greg