mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Ogness <john.ogness@linutronix.de>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Derek Barbosa <debarbos@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH RFC printk] printk: Postpone kthread startup
Date: Thu, 15 Oct 2026 15:13:23 +0206	[thread overview]
Message-ID: <87ecdrqfhw.fsf@jogness.linutronix.de> (raw)

There have been various bug reports related to SMP systems hanging
on boot. The reports vary wildly but seem to have some overlap with
regard to missed IPI's during SMP setup. The reports also show that
reverting NBCON console usage allows the bugs to disappear.

The NBCON kthreads for console printing are started very early
during boot using early_initcall(). Since these kthreads are
actively enabling/disabling interrupts during early boot, they may
be interfering with SMP setup.

Postpone kthread starting until after all arch initcalls have
completed.

Signed-off-by: John Ogness <john.ogness@linutronix.de>
---
@pmladek: This patch came about from the RedHat reports we were talking
about at LPC. Derek is still doing final testing, but this patch most
likely fixes the issue. We probably will want this for the 7.3-hotfix in
order to preempt any other surprise bug reports.

It would be nice to start the kthreads sooner, but it is not worth
possibly hanging some sensitive (buggy?) hardware.

 kernel/printk/nbcon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/printk/nbcon.c b/kernel/printk/nbcon.c
index f05cc90123bd4..04fdd71b37e55 100644
--- a/kernel/printk/nbcon.c
+++ b/kernel/printk/nbcon.c
@@ -1475,7 +1475,7 @@ static int __init printk_setup_threads(void)
 	console_list_unlock();
 	return 0;
 }
-early_initcall(printk_setup_threads);
+subsys_initcall(printk_setup_threads);
 
 /**
  * nbcon_alloc - Allocate buffers needed by the nbcon console

             reply	other threads:[~2026-10-15 13:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 13:07 John Ogness [this message]
2026-10-15 13:30 ` John Ogness

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ecdrqfhw.fsf@jogness.linutronix.de \
    --to=john.ogness@linutronix.de \
    --cc=debarbos@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®