From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A4C130C17C for ; Mon, 18 May 2026 10:29:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779100198; cv=none; b=SvvFdpdfyX2dpoPR2XdKc2SZgwAVGFl0jxxlFAw5Q/Wj3j3R1KRtSBmEI7FjGuh7DEQQlVvgG0l+fjd/nitANraHxHyYSz24eXBitwl6psHkglxZKY7kHx515DrnYpYzqwCUJ8gcn5vsAln+jeuchQsOWBCJpAUOaJri6cETuGk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779100198; c=relaxed/simple; bh=y3kaX460aTBxEbaSJiZkvz9ZTqi4PQBUiOo0ceVC3BU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=XjPuWeiJOgB1090NcXMY3eKEJswM78E+khbmfAH99T9UR5+mHuDvD7W7l6moCUx3kdsvGWvhpW57xn4AWE0odo/oLtbWkerogMET1pIbSz5HshwvtF8YxdFgo+Exie8fS1Wtnrt1wPUtSJ2nj3xkPtOckGwaCOlbuJzaG6KoFaA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bFm55wE8; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=GBZO2brP; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bFm55wE8"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="GBZO2brP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779100185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=06m9OVWKqpnsGVT1SKIUZ2m40GcgZTxTHQ+S3N+VJ20=; b=bFm55wE8xTHzepczvD8wGF5Fe04LPl6b6kAJBHiPumdrQK9upLHCmolxZ8QC948iCn8o0L Eam/U0vIWXgMHOmqeBjnQCRtKrcOoLSk5IH2uiTG4aQwfoXaVmsDdjeEBOTnux1A78FTyR VmHS/EzUfzruipkFXoyzLRwk7ytMl2U= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-404-7ZxILXo5OGimvIZgpF0RTw-1; Mon, 18 May 2026 06:29:44 -0400 X-MC-Unique: 7ZxILXo5OGimvIZgpF0RTw-1 X-Mimecast-MFC-AGG-ID: 7ZxILXo5OGimvIZgpF0RTw_1779100182 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-45e78dd7baaso1001584f8f.0 for ; Mon, 18 May 2026 03:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779100182; x=1779704982; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=06m9OVWKqpnsGVT1SKIUZ2m40GcgZTxTHQ+S3N+VJ20=; b=GBZO2brPwCzF7HaEf1hC+fdsLLpAMnMTPpaek3L+1psJ4CXV1jRtcys8KrL4IRGK3m oNzkQLAALlCukiUXzZSSgjh86a1aY/QqqOqKwVvSt37XtS2/AU6gExzQFiVd9r+j0OQX oW0KZz7jlKwhbLV6fQo5XxO8lapgbXtjjbPJ/HjxZk+A/GosFv08bywRBQPfy44PXO3x 0EQ/TvilZ+491ZyKoHzz0vvVt5OAkdZC6BjgQ9pNG2ORqbUhbZsGpeyYlDDkO26e2wtR mVi0A05qhREfee37LKCpNOTN/y8qwK+GuqQUTplR64laCjMysOoPRwfP9d7Gpy5xV+cP E92g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779100182; x=1779704982; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=06m9OVWKqpnsGVT1SKIUZ2m40GcgZTxTHQ+S3N+VJ20=; b=ENWo4zBSgvBF8n0xZaJ3x/e8pOLmrVhVZB3XWNG784KrzlFN2yRRICRfPxbVMlNjf+ 4Pzg9lLPOpF15M/1XFD4k8Y9B+T4knywAMkrrX91OJl1AAPLsum98Wsys1kzta/Swgsk 4nHGxxPXtqN59o2gsggbbm9OBKnlDn58EH76NiMoxyFFCgyL1uU1xFB/pCWcxSBgPDCb mC1RrdvWi8fK8+As82GAALvy+hqZs6+VD8lz0/oSDEJCDEpciTO5lYWdOvhJv48jeqld +DzUzkbdVzrM5wzjUd3nJU2bz1aLT4ymWsduTp/ZdKAXZT1MqVyx/qcNs1MngIq98wFa uskw== X-Forwarded-Encrypted: i=1; AFNElJ/4KJcadVuNo9sY8xPsgmFSaqzg0/tozVeTsTF1CPOKunOU/rYKiKGQQKiFplj7AOjn4Vhv8/tax3ggBh0=@vger.kernel.org X-Gm-Message-State: AOJu0YyQlJuHKunnGQ8vjANKnoM7ocwhb4UMFKBOCSkqrOEjPnvPaqb3 F4UWt883fBpkMdYuT+gyry0dg2KwlWF8OTMO0rL8X9IPYkvCdSx5AUZSqBrP8pQ9kX1BCzhnCCG 8r+NwkjAmgKo5pvm3E2e5GFVVS3CzOku6J7gmT2v9/kWfpGQoTVQti2ivEI+yS3V64A== X-Gm-Gg: Acq92OGgw5zulx6nCKgc0ta5XTk38FmJ17NFBWMNStKDr6eNWvY/VhKi31jC9EX4tRX QY7MbLjbXPniVVcZboZYpp+l8tWG3v5xiei2PQpcYePO0o5kGVOUtQKnnShCRQzUDBezKGLCSgt JhCmmOfl21NasMa5XnLagJRMrox+EqdtXTg/Xafj1UqwC3lMqBAqXpr6I3q+GZHhN5I0vc8aX5G SaqcZnSozPXwVa+D7pN2qPCLD446tMJqqYocEaWVeMym5+75jaM0ZL1q3uu7Cj7tpBJS266c6ue sSH7AJkZ1IRzyCqLuQxQV551OFujT0Uk2XgqdyVKlfZEh0KhbXezg+RlnB6M8HcnyOzgmTRI8/B qBES6zaKwYqv9HpukDg5gpSAIi+NMdRCrDG5sQfcNEOCfmXqUvZMUYl2Ds2KHFD7Lh051mIIDpJ zSgrty X-Received: by 2002:a05:600c:c10b:b0:48f:d1b8:9aa4 with SMTP id 5b1f17b1804b1-48fe5fcdef4mr168629465e9.7.1779100181755; Mon, 18 May 2026 03:29:41 -0700 (PDT) X-Received: by 2002:a05:600c:c10b:b0:48f:d1b8:9aa4 with SMTP id 5b1f17b1804b1-48fe5fcdef4mr168629045e9.7.1779100181295; Mon, 18 May 2026 03:29:41 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe537c516sm267101625e9.13.2026.05.18.03.29.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 03:29:40 -0700 (PDT) From: Javier Martinez Canillas To: Sen Wang , ple@baylibre.com, neil.armstrong@linaro.org, dmitry.baryshkov@oss.qualcomm.com Cc: andrzej.hajda@intel.com, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, devarsht@ti.com, s-jain1@ti.com, j-sahu@ti.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sen Wang Subject: Re: [PATCH v2] drm/bridge: ite-it66121: Convert to DRM HDMI Audio Helper In-Reply-To: <20260318154636.3230454-1-sen@ti.com> References: <20260318154636.3230454-1-sen@ti.com> Date: Mon, 18 May 2026 12:29:39 +0200 Message-ID: <87ecj9xb70.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Sen Wang writes: Hello Sen, > Convert the IT66121 HDMI bridge driver from manually registering an > hdmi-codec platform device to using the DRM HDMI Audio Helper framework > via DRM_BRIDGE_OP_HDMI_AUDIO instead. > > The previous implementation manually allocated hdmi_codec_pdata, > registered the platform device, and implemented hdmi_codec_ops callbacks > including get_eld. The new approach sets DRM_BRIDGE_OP_HDMI_AUDIO on the > bridge, letting the framework handle the codec registration. This also > resolves some non-compliance issues with the current audio implementation, > such as HDMI audio advertising a non-functional capture stream to userspace. > > The audio callbacks are converted from hdmi_codec_ops signatures to > drm_bridge_funcs hdmi_audio callbacks: > - it66121_audio_hw_params -> it66121_hdmi_audio_prepare > - it66121_audio_startup -> it66121_hdmi_audio_startup > - it66121_audio_shutdown -> it66121_hdmi_audio_shutdown > - it66121_audio_mute -> it66121_hdmi_audio_mute_stream > > The it66121_audio_get_eld, it66121_audio_codec_ops, and > it66121_audio_codec_init functions are removed as the framework handles > these responsibilities. > > Suggested-by: Dmitry Baryshkov > Signed-off-by: Sen Wang > --- The patch looks correct to me but I'm not that familiar with the HDMI helpers, so it would be great if either Dmitry or Maxime could take a look to the changes before merging it. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat