From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BA2630C145 for ; Fri, 5 Jun 2026 22:20:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780698014; cv=none; b=dNDvze5rs7WeoZ/ls+4qJH+pHWv0AiHl/JBvIpCYprq4GBzwrgp0fuaEHHd8lY5/iPE/If69QKzn9KK4n9FfpT1Z1Q+af0zfUlSXWG+6tAfd86IOEPSgheQD60LTfR+OktQrcmHPZrGNJoXy4wrcrGNyWEe56gE3bKdEjttDseE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780698014; c=relaxed/simple; bh=/fJR9ObIjB90E/QkVHybSi2y1A5XCak5hCNjolyBIsI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=C46TPtw3MjtEhlKJhKAFsYdzedDK3HagY0j6+CmLsrFkIjV2pqjwvoGSc9bYxUxnMDOooJ7L1pIJbGSzP8Mo7lRbrgG4PaWs65+2RWWK7Utn3kTKVhy1wJiNZzH3eXmmW0+Xh/DXLld4Iw5CRbiExoP1ww6e2lTqT0Ksl1lJf/0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=v9qFIcGf; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="v9qFIcGf" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-46019edc13dso1136319f8f.1 for ; Fri, 05 Jun 2026 15:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1780698011; x=1781302811; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=p/HB8G1yTQPOAvgzKZeKYVge98Lt9ZnLKHPu1l7zZb4=; b=v9qFIcGf3AzlWTMlJODbm2DBzIdu3pdSB9KlLvoOgaTA8nN64Jb61RDdKdVCLNgnlM aCDmRUI/U0Ee5CwyRPjMDWUvAliXoPY3dLNnLzswOQGKmxsaS9bWrwleM9TzZt5WfgV3 cmJc5xsjyi4QT9RQC03L2Boxtr1yu/xacJ36vkGXcKV30BA4oRpCHJojx/pNdDyrP7Nq NTKAv9ZXSJB4H5gPlX0xc4QfP5CTwI83/Fy0A+5V9skGxkDCHOjRjPOm9gmxz5LRWKUw OoAqeGVMiO7VRAt3p+7mhdL4VMqOps2D+kBzKZQH/ijRjkXOSV28ciC4NvxcZlkfK9Jy lc2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780698011; x=1781302811; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p/HB8G1yTQPOAvgzKZeKYVge98Lt9ZnLKHPu1l7zZb4=; b=bkIJZMZMRcVtoFyrN5kfV+ArR/fLm2Lo1cylcsimcKMAKXberMTitsERraGfwB508L WALmwX7BWXaoUCTUML+vSxZL7vMDEZefY5GbZaXvMCDiw4ne0Siwdie3o1J6Cd8ZsVcM 3yzr8Bt3uIUi7YMqlTDQc4BwAo3uaRfYwgKFIeRpRQvEhFmdtsOEESTFbRd+7P4pS/lk TjGFfiMQGmMtHGP/TJf3epoHnvy+DNo1GlKxI/a1vXR+7CwYYwIaVhdYqgyfQABzs5Jq FkENyb9Xoq2iaaYCy06ThbtzgZvUYbM6LDVsDAw8pDXHphoQiTWtsX9AAIP0TUsSUXwd V0YQ== X-Forwarded-Encrypted: i=1; AFNElJ/6YpKhlJ/C4Vj2rhjBBkLmjtM+S+dtfb54M5dlBWTCTi5aTIXn1C7lBvZ+BUXVut6wumwnX14EOw8PSH0=@vger.kernel.org X-Gm-Message-State: AOJu0YyPWC0rfBU08N8u+a+LTDgICscibTyFC2JymoaQFN1wE0VRLjiU ZsGpgdBZN7jhtweieNedT1T9DD8IU9NvoA5cr0Ov+rrbPm5fL/TVLzZt8rvqc+1AA3c= X-Gm-Gg: Acq92OFZT0iFSeOS28uFyabBQ2yykmsmAcBZeKcRZNAJqo0NG/FfZ8I7YdogvT5eeum oiuymG3vgSGwNHilud6s9H6Op4ddXx7D0ZE6ksVutthGORepNP3bQ5fBwd0tdI6PXxiAw1yE4Lu VZQhuoQ98OazJsOC8rnxVogb31NCU9swjSXtD+Vfs+BzSloZwKo7l0xLNZzAGKRp9JJ31yizF0r ZjQOilY0Z1kT1O84xDtdyspsmuMIJvoxwMQ962xWdmRLfDeX05mDnXynCD90aU40PDVyEfotSAX ghh1JMhKz5q9AaaiVoNbwit9HL+YfOmEncXuv2g0gNvYEviN94WMnaCb/1fK8/Zv5pV2QqYbNLY AGy96B7LRHB0E1jruaQNKYuGuGterFtGnNrcZtHJ2XA1NG6xFSrW/lEMmaNh8Ko0GiI12grsZLM DZj1TqmocsWkg2a4L6TQAgHvAnyrDolWzv82ZzqQPRRR29 X-Received: by 2002:adf:e743:0:b0:45e:f1c5:709 with SMTP id ffacd0b85a97d-4603076cb46mr6547079f8f.37.1780698010560; Fri, 05 Jun 2026 15:20:10 -0700 (PDT) Received: from [192.168.0.101] ([109.77.32.74]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f351d40sm28849253f8f.26.2026.06.05.15.20.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jun 2026 15:20:09 -0700 (PDT) Message-ID: <87ed4bcc-aa66-4a1f-becc-7fce1fe795c1@linaro.org> Date: Fri, 5 Jun 2026 23:20:06 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 5/8] media: qcom: camss: csiphy-3ph: Add Gen2 v1.1 MIPI CSI-2 C-PHY init To: Michael Srba , Bryan O'Donoghue , Frank Li , David Heidelberg Cc: Robert Foss , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Luca Weiss , Petr Hodina , "Dr. Git" , Cory Keitz , Loic Poulain , Konrad Dybcio , Kieran Bingham , Sakari Ailus , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20260603-qcom-cphy-v6-0-e50de0b557a8@ixit.cz> <20260603-qcom-cphy-v6-5-e50de0b557a8@ixit.cz> <8azU3NvUdGCvWCxLb0gz7FWkTGFL4k_xiBUPp170jiYIQjwHyRqynP_oLG4pjFkIRSY_bo91FQh9ECYlXdXrsw==@protonmail.internalid> <8b9f8754-48da-4b61-84b8-3688520c7f63@kernel.org> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/06/2026 15:47, Michael Srba wrote: >> So, hex values from downstream in this case are acceptable. >> >> OTOH vendors can and should enumerate their registers in an upstream >> submission. > I thought this was the policy indeed, but this made me wonder if ALL the > magic numbers > in that file were added by volunteers. And weirdly I found this: > https://github.com/torvalds/linux/ > commit/7803b63a1640a0a39e3ebad487b33cb2d26e778b > and possibly some other commits look like they were made by people on > Qualcomm's > payroll. This specifically is QUIC, and idk how much documentation > access they have, > but at minimum I assume they had access to the CTRLn register names? > (fwiw it's entirely > plausible that the registers don't actually *have* better names). > > I didn't follow the relevant ML discussions, but it seems to me like > they should've > been told to document the registers? "That money was just resting in my account" There's alot of technical debt to digest, which I think should be solved in the new PHY API driver. - Move to new driver - Start enumerating registers correctly - Transition to QMP PHY levels of lane config instead of long lists of "mission mode" writes. If you ever rent a car in Ireland and get lost, you might ask a local "how do I get to Tip from here" and we'd scratch our heads under a flat cap and say something like "ah well shure, I wouldn't start from here" ;) --- bod