From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9604EE49A3 for ; Fri, 25 Aug 2023 07:48:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243241AbjHYHs0 (ORCPT ); Fri, 25 Aug 2023 03:48:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242989AbjHYHsN (ORCPT ); Fri, 25 Aug 2023 03:48:13 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 438281FD8; Fri, 25 Aug 2023 00:48:10 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AEE341F8B2; Fri, 25 Aug 2023 07:48:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1692949688; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mYpRgKkqPnZRHXbdkwIwj/vSbyT7RcD8xYt4PaeABDU=; b=zwXWUoG+oI1n1JCYPZkhcklkmNUNOTGoNyN1sHWOJimdhyaTjDvIYnXAC0inRU20E0Mi4k 6+BqgWGf1IUOqPYAX6VlBL5VjFhK8OmcgGJoORlWvANypiqpeLbzjwmRlcfTxkS0mNiyK0 7EU7tkFNNlmZHr40mrC/ss9N5JqY2Vw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1692949688; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mYpRgKkqPnZRHXbdkwIwj/vSbyT7RcD8xYt4PaeABDU=; b=hZUWIjwjINKZ5e6ttlkKPJjGoVkxu4+Lg78g5wlJ63BG5ENx1bG9WKPyET3wwo5zElAt5Y nhPfAJCfNgEDyqBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 22E731340A; Fri, 25 Aug 2023 07:48:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id SK2jB7hc6GQdUQAAMHmgww (envelope-from ); Fri, 25 Aug 2023 07:48:08 +0000 Date: Fri, 25 Aug 2023 09:48:07 +0200 Message-ID: <87edjr8sw8.wl-tiwai@suse.de> From: Takashi Iwai To: Sui Jingfeng Cc: Bjorn Helgaas , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, linux-pci@vger.kernel.org, alsa-devel@alsa-project.org, Sui Jingfeng , Jaroslav Kysela , Takashi Iwai , Fred Oh , Pierre-Louis Bossart , Kai Vehmanen Subject: Re: [PATCH 2/5] ALSA: hda/intel: Use pci_get_base_class() to reduce duplicated code In-Reply-To: <20230825062714.6325-3-sui.jingfeng@linux.dev> References: <20230825062714.6325-1-sui.jingfeng@linux.dev> <20230825062714.6325-3-sui.jingfeng@linux.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 25 Aug 2023 08:27:11 +0200, Sui Jingfeng wrote: > > From: Sui Jingfeng > > Should be no functional change > > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: Fred Oh > Cc: Pierre-Louis Bossart > Cc: Kai Vehmanen > Cc: Bjorn Helgaas > Signed-off-by: Sui Jingfeng > --- > sound/pci/hda/hda_intel.c | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > index a21b61ad08d1..811a149584f2 100644 > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -1429,17 +1429,11 @@ static bool atpx_present(void) > acpi_handle dhandle, atpx_handle; > acpi_status status; > > - while ((pdev = pci_get_class(PCI_CLASS_DISPLAY_VGA << 8, pdev)) != NULL) { > - dhandle = ACPI_HANDLE(&pdev->dev); > - if (dhandle) { > - status = acpi_get_handle(dhandle, "ATPX", &atpx_handle); > - if (ACPI_SUCCESS(status)) { > - pci_dev_put(pdev); > - return true; > - } > - } > - } > - while ((pdev = pci_get_class(PCI_CLASS_DISPLAY_OTHER << 8, pdev)) != NULL) { > + while ((pdev = pci_get_base_class(PCI_BASE_CLASS_DISPLAY, pdev))) { > + if ((pdev->class != PCI_CLASS_DISPLAY_VGA << 8) && > + (pdev->class != PCI_CLASS_DISPLAY_OTHER << 8)) > + continue; > + > dhandle = ACPI_HANDLE(&pdev->dev); > if (dhandle) { > status = acpi_get_handle(dhandle, "ATPX", &atpx_handle); Reviewed-by: Takashi Iwai thanks, Takashi