From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86AD7C76195 for ; Mon, 27 Mar 2023 08:17:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232724AbjC0IRD (ORCPT ); Mon, 27 Mar 2023 04:17:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232667AbjC0IRA (ORCPT ); Mon, 27 Mar 2023 04:17:00 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC6355255 for ; Mon, 27 Mar 2023 01:16:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679904973; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dqM4HxKTQa8CAlzTf6R5B7JwdVrZ3pTGuhEoPvMHOiA=; b=ire0i4u5UjASnCxnWJzk82t7I8oiDhk5QbsRdp8zt0TUpozFsVNwB5Xub2C6qvYD19ZHZN ltrNWqTYAgQC3oyUP1NTTY+0vJHRzRQ55SUJdhkYBVrPetxpXvxStuTK6q4kcPn0MUVkVn m0AVqRY8NTkdcydpgCfg4x9XzQJxqUo= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-208-NpnutbZtNu25V9jXgiH7YQ-1; Mon, 27 Mar 2023 04:16:11 -0400 X-MC-Unique: NpnutbZtNu25V9jXgiH7YQ-1 Received: by mail-wr1-f70.google.com with SMTP id d18-20020adfa412000000b002d43970bb80so611415wra.6 for ; Mon, 27 Mar 2023 01:16:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679904970; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dqM4HxKTQa8CAlzTf6R5B7JwdVrZ3pTGuhEoPvMHOiA=; b=daYNmCSCfKTWpQbRluaxDFN79e0XC2DYjf8UdCYGU26Y+dYWNBL/DGdgPOflw8FyFH JHEngupK9RjzfjjxMI9+6eqaPtBSMmMNTz32bhZpxFgmsait32nVXsKEc4X2SxJIfOBT cGIJS+I5ePBRyBxdNrtP7uEHrNDKioQdEaRa1HtlVuttCmhIAb2pF8k5aiVwUd4XgWth X4dm3cSgtf+nOR0AMdyJ1+K2qcOlOilRoK6hShhjwQSkGeeajBgD0yDOJhrqR6suup2d gnn4xdlQyKMzqnU0dnbGCF4hPIwhtJzF3w1UNLq650wyUrVfFZxxeVJcdr0xpwzFZyZO totA== X-Gm-Message-State: AO0yUKUu1H8FSskJ0t13rscLZmGZufScuqbu3iy7cMuQA+arsCo/WLAW Dbq/PHWku5ptTWvgpq1x1qNKH5VZGxhOa7A8H591JUYva94+ZLmkeKjdufZ4Dgi9t5ykiNrJbeB eqOvbpkbAF1t6BM8XTDyDl3E4hv+hO0Oi X-Received: by 2002:a1c:7318:0:b0:3ed:3cec:d2ec with SMTP id d24-20020a1c7318000000b003ed3cecd2ecmr9224591wmb.15.1679904969985; Mon, 27 Mar 2023 01:16:09 -0700 (PDT) X-Google-Smtp-Source: AK7set8ZUoTXxMxtwd0sU6jQR8jMhRDwPLktCNTgCwqGs+AGnExW7nkz8pp+TofqXoPOE6jQzeNX9w== X-Received: by 2002:a1c:7318:0:b0:3ed:3cec:d2ec with SMTP id d24-20020a1c7318000000b003ed3cecd2ecmr9224554wmb.15.1679904969577; Mon, 27 Mar 2023 01:16:09 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id t14-20020a05600c198e00b003ef66c89af0sm7017891wmq.0.2023.03.27.01.16.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 01:16:09 -0700 (PDT) From: Javier Martinez Canillas To: Jarrah , linux-kernel@vger.kernel.org Cc: Robert Mader , Laurent Pinchart , Peter Robinson , Jacopo Mondi , Ondrej Jirman , Martijn Braam , Kamil =?utf-8?Q?Trzci=C5=84ski?= , Caleb Connolly , Heiko Stuebner , Krzysztof Kozlowski , Rob Herring , Tom Fitzhenry , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2] arm64: dts: rk3399-pinephone-pro: Add internal display support In-Reply-To: References: <20230327074136.1459212-1-javierm@redhat.com> Date: Mon, 27 Mar 2023 10:16:08 +0200 Message-ID: <87edpatxrr.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jarrah writes: > Hi Javier, > > On 3/27/23 18:41, Javier Martinez Canillas wrote: >> From: Ondrej Jirman >> >> The phone's display is using a Hannstar LCD panel. Support it by adding a >> panel DT node and all needed nodes (backlight, MIPI DSI, regulators, etc= ). >> >> Signed-off-by: Ondrej Jirman >> Co-developed-by: Martijn Braam >> Co-developed-by: Kamil Trzci=C5=84ski >> Signed-off-by: Javier Martinez Canillas >> --- >> >> Changes in v2: >> - Drop touchscreen node because used the wrong compatible (Ondrej Jirman= ). > > > Any reason not to include this with the correct compatible string? It's=20 > been available since=20 > https://lore.kernel.org/all/20220813043821.9981-1-kernel@undef.tools/.=20 > Swapping out gt917s for gt1158 in the node from your previous patch=20 > should be enough. > Yes, but I didn't know that the driver already had the compatible string so I just dropped it for now and was meaning to take a look to that later. Adding the touchscreen node can be done as a follow-up though in another patch. --=20 Best regards, Javier Martinez Canillas Core Platforms Red Hat