From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68D66C433EF for ; Tue, 25 Jan 2022 03:00:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1315764AbiAYCyJ (ORCPT ); Mon, 24 Jan 2022 21:54:09 -0500 Received: from out01.mta.xmission.com ([166.70.13.231]:39108 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S3408073AbiAYAVd (ORCPT ); Mon, 24 Jan 2022 19:21:33 -0500 Received: from in02.mta.xmission.com ([166.70.13.52]:40422) by out01.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1nC9aR-001AUJ-QT; Mon, 24 Jan 2022 17:21:28 -0700 Received: from ip68-110-24-146.om.om.cox.net ([68.110.24.146]:53348 helo=email.froward.int.ebiederm.org.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1nC9aP-00E0KF-8z; Mon, 24 Jan 2022 17:21:26 -0700 From: "Eric W. Biederman" To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Andrew Morton , linux-ia64@vger.kernel.org, Tony Luck , kernel test robot , Christoph Hellwig References: <20220124213129.29306-1-rdunlap@infradead.org> Date: Mon, 24 Jan 2022 18:20:54 -0600 In-Reply-To: <20220124213129.29306-1-rdunlap@infradead.org> (Randy Dunlap's message of "Mon, 24 Jan 2022 13:31:29 -0800") Message-ID: <87ee4w1x95.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1nC9aP-00E0KF-8z;;;mid=<87ee4w1x95.fsf@email.froward.int.ebiederm.org>;;;hst=in02.mta.xmission.com;;;ip=68.110.24.146;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1+l7gNz9P0ebhyrkVdO1CIxfUNRBVsTFsw= X-SA-Exim-Connect-IP: 68.110.24.146 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH -next v2] ia64: make IA64_MCA_RECOVERY bool instead of tristate X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Randy Dunlap writes: > In linux-next, IA64_MCA_RECOVERY uses the (new) function make_task_dead(), > which is not exported for use by modules. Instead of exporting it for > one user, convert IA64_MCA_RECOVERY to be a bool Kconfig symbol. > > In a config file from "kernel test robot " for a > different problem, this linker error was exposed when > CONFIG_IA64_MCA_RECOVERY=m. > > Fixes this build error: > > ERROR: modpost: "make_task_dead" [arch/ia64/kernel/mca_recovery.ko] undefined! Reviewed-by: "Eric W. Biederman" I looked and ia64_unreg_MCA_extension has no synchronization so I don't think it has ever been safe to this code when built as a module. > Fixes: 0e25498f8cd4 ("exit: Add and use make_task_dead.") > Signed-off-by: Randy Dunlap > Cc: "Eric W. Biederman" > Cc: Andrew Morton > Cc: linux-ia64@vger.kernel.org > Cc: Tony Luck > Cc: kernel test robot > Suggested-by: Christoph Hellwig > --- > v1 was [PATCH -next] exit: export make_task_dead(). > Christoph suggests and prefers that IA64 MCA recovery code just be > forced to be builtin if it is enabled. > > arch/ia64/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20220121.orig/arch/ia64/Kconfig > +++ linux-next-20220121/arch/ia64/Kconfig > @@ -318,7 +318,7 @@ config ARCH_PROC_KCORE_TEXT > depends on PROC_KCORE > > config IA64_MCA_RECOVERY > - tristate "MCA recovery from errors other than TLB." > + bool "MCA recovery from errors other than TLB." > > config IA64_PALINFO > tristate "/proc/pal support"