From: Thomas Gleixner <tglx@linutronix.de>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Davidlohr Bueso <dave@stgolabs.net>, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] perf bench: Share 'start', 'end', 'runtime' global vars
Date: Tue, 03 Mar 2020 19:28:52 +0100 [thread overview]
Message-ID: <87eeu92syj.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20200303155811.GD13702@kernel.org>
Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com> writes:
>> > Don't we have header files for that?
>
>> Sure, that was the laziest/quickest way to "fix" that, the other was to
>> stick a 'static' in front of it.
>
>> I'll go see if pushing them to a header file will not clash with other
>> stuff.
>
> Better now? Had to prefix those, not to clash with local variables when
> adding it to bench/bench.h.
Yes.
> Looking at the patch more can be done to share those benchmark
> arguments, but this is the second minimal patch to get tools/perf to
> build with the latest gcc (the one in Fedora rawhide and some other
> distros).
Right, but yes there is definitely quite some overlap there.
Acked-by: Thomas Gleixner <tglx@linutronix.de>
next prev parent reply other threads:[~2020-03-03 18:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 15:09 [PATCH] " Arnaldo Carvalho de Melo
2020-03-03 15:28 ` Thomas Gleixner
2020-03-03 15:36 ` Arnaldo Carvalho de Melo
2020-03-03 15:58 ` [PATCH v2] " Arnaldo Carvalho de Melo
2020-03-03 18:28 ` Thomas Gleixner [this message]
2020-03-03 19:19 ` Arnaldo Carvalho de Melo
2020-03-04 11:01 ` [tip: perf/urgent] perf bench: Share some global variables to fix build with gcc 10 tip-bot2 for Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eeu92syj.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=adrian.hunter@intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=dave@stgolabs.net \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®