mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, mawilcox@microsoft.com,
	ynorov@caviumnetworks.com, andriy.shevchenko@linux.intel.com,
	geert@linux-m68k.org, keescook@chromium.org,
	torvalds@linux-foundation.org
Subject: Re: [PATCH] lib/test_bitmap.c: Fix bitmap optimisation tests to report errors correctly
Date: Fri, 11 May 2018 23:48:28 +1000	[thread overview]
Message-ID: <87efiiqp5f.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20180509155956.4132815b34c4e7421aaab0a7@linux-foundation.org>

Andrew Morton <akpm@linux-foundation.org> writes:
> On Wed,  9 May 2018 21:43:28 +1000 Michael Ellerman <mpe@ellerman.id.au> wrote:
>> From: Matthew Wilcox <mawilcox@microsoft.com>
>> 
>> I had neglected to increment the error counter when the tests failed,
>> which made the tests noisy when they fail, but not actually return an
>> error code.
>> 
>> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
>> Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>
>> Fixes: 3cc78125a081 ("lib/test_bitmap.c: add optimisation tests")
>> Cc: stable@vger.kernel.org # v4.13+
>> Tested-by: Michael Ellerman <mpe@ellerman.id.au>
>
> I'll add your SOB to my copy of this, as you were on the patch delivery path.

Ah yep, I wasn't on the original delivery path, but you're right I am now.

Thanks for fixing it up.

cheers

      reply	other threads:[~2018-05-11 13:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-09 11:43 Michael Ellerman
2018-05-09 17:16 ` Kees Cook
2018-05-11 13:47   ` Michael Ellerman
2018-05-09 22:59 ` Andrew Morton
2018-05-11 13:48   ` Michael Ellerman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efiiqp5f.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=geert@linux-m68k.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mawilcox@microsoft.com \
    --cc=torvalds@linux-foundation.org \
    --cc=ynorov@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®